Port #[rustc_dummy]

[mejrs]

r? @jdonszelmann

[rustbot]

jdonszelmann is not on the review rotation at the moment.
They may take a while to respond.

[rustbot]

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

[jdonszelmann]

Needs a little bit of work. If you're using the attr in an invalid position it'll be checked twice now (take a look at the other prs how they solve this)

[jdonszelmann]

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[GrigorenkoPV]

Needs a little bit of work. If you're using the attr in an invalid position it'll be checked twice now (take a look at the other prs how they solve this)

In compiler/rustc_parse/src/validate_attr.rs, in check_builtin_meta_item you need to add sym::rustc_dummy to the giant match pattern. I'm not aware if anything else is needed.

And, as a personal request, could you please add it not next to inline, may_dangle, rustc_pass_by_value, or repr — it would help with avoiding conflicts with #143402 & #143403.

[mejrs]

you need to add sym::rustc_dummy to the giant match pattern. I'm not aware if anything else is needed.

I don't, actually. That pattern is unreachable, because check_builtin_meta_item is never called for rustc_dummy.

[jdonszelmann]

I see

[jdonszelmann]

@bors r+ rollup

[bors]

📌 Commit 429deed has been approved by jdonszelmann

It is now in the queue for this repository.

[Kobzol]

@rust-timer build 8867650

Testing tiny regression in #143645.

[rust-timer]

Queued 8867650 with parent f838cbc, future comparison URL.
There is currently 1 preceding artifact in the queue.
It will probably take at least ~2.2 hours until the benchmark run finishes.