clippy_dev: parsing revamp 1/N
#15866
Conversation
rustbot
added
the
S-waiting-on-review
|
Commit messages of commits 3 and 6 need to be shortened to be properly displayed by git |
|
Since I've reviewed this already as part of #15921 r? samueltardieu |
Wait, do we really care about this? 👀 Short headings in commit messages are appreciated, but I think strictly limiting this to 80 characters is a bit outdated nowadays. |
Github still shows them poorly in some places such as in the current PR, if you review by commit, you'll see for the third one: But it looks like this is fixed in the other places (and in fine in git's and jj's clis), so I'll withdraw my request and merge this. |
rustbot
removed
the
S-waiting-on-review
Based on #15866 This adds a parsing context that can allocate from an arena. Ultimately this will also store a source map for better error reporting, but a few other changes are happening before that. The arena itself is unlikely to be needed from a perf standpoint (reading all the files should be the slow part), but having more things be copyable is nice. For reference the perf impact of this change is within the noise. changelog: none
5 participants
Supercedes #15270
This first PR just moves the existing code and simplifies a few things. The switch to use the new range API isn't really used in this PR , but it's needed by future changes to avoid having to add
.clone()all over the place.changelog: none