clippy_dev: Parsing revamp part 2/N
#15921
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
rustbot has assigned @samueltardieu. Use |
| pub fn deprecate(clippy_version: Version, name: &str, reason: &str) { | ||
| let mut lints = find_lint_decls(); | ||
| let (mut deprecated_lints, renamed_lints) = read_deprecated_lints(); | ||
| pub fn deprecate<'cx, 'env: 'cx>(cx: ParseCx<'cx>, clippy_version: Version, name: &'env str, reason: &'env str) { |
There was a problem hiding this comment.
None of those lifetimes are necessary
clippy_dev/src/parse.rs
Outdated
| impl ParseCxImpl { | ||
| /// Finds all lint declarations (`declare_clippy_lint!`) | ||
| #[must_use] | ||
| pub fn find_lint_decls(&mut self) -> Vec<Lint> { |
There was a problem hiding this comment.
Nit: It is strange that in this commit &mut self is used as a parameter and never used. This would not pass dogfood should the PR be partially merged up to this commit.
clippy_dev/src/parse.rs
Outdated
| } | ||
|
|
||
| #[must_use] | ||
| pub fn read_deprecated_lints(&mut self) -> (Vec<DeprecatedLint>, Vec<RenamedLint>) { |
There was a problem hiding this comment.
Same nit as above about &mut self
samueltardieu
added
the
S-blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #15866
This adds a parsing context that can allocate from an arena. Ultimately this will also store a source map for better error reporting, but a few other changes are happening before that.
The arena itself is unlikely to be needed from a perf standpoint (reading all the files should be the slow part), but having more things be copyable is nice. For reference the perf impact of this change is within the noise.
changelog: none