Add --id flag to cargo report timings and cargo report rebuilds
#16490
+257
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-cli
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
Member
|
Thanks for the contribution! FWIW, we usually follow a variant of atomic commit pattern:
Every commit passes, and the test/snapshot diff shows the behavior change. Any feel free to rebase and fix-up your commit history! |
Contributor
|
For the initail test commit, I would leave off |
epage
reviewed
Jan 9, 2026
| .arg_manifest_path() | ||
| .arg(flag("open", "Opens the timing report in a browser")), | ||
| .arg(flag("open", "Opens the timing report in a browser")) | ||
| .arg(opt("id", "Session ID to report on").value_name("ID")), |
This adds the `--id` argument to the CLI definitions but does not yet implement the functionality. The argument is currently accepted but ignored; the commands still use the most recent session by default. This commit also adds tests that verify the current behavior (using the most recent session) in preparation for the next commit which implements the `--id` functionality.
…builds` This implements the `--id` flag that was added in the previous commit. When specified, the commands will report on the session with the given ID instead of the most recent session. The implementation adds a `find_log_file` helper that searches for a specific session ID when provided, or falls back to returning the most recent session when no ID is specified. Error handling is updated to provide helpful messages: - When a specific ID is not found, users are directed to `cargo report sessions` to list available sessions - Invalid ID formats are rejected with a clear error message
terror
force-pushed
the
cargo-report-id
branch
from
4b00fea to
de85543
Compare
Contributor
Author
Thanks for the heads up, just went ahead and re-wrote the commits to reflect this convention :) |
weihanglo
approved these changes
Jan 9, 2026
rustbot
removed
the
S-waiting-on-review
rust-bors bot
added a commit
to rust-lang/rust
that referenced
this pull request
Jan 11, 2026
Update cargo submodule 5 commits in 8c133afcd5e0d69932fe11f5907683723f8d361d..6d1bd93c47f059ec1344cb31e68a2fb284cbc6b1 2026-01-09 03:50:15 +0000 to 2026-01-10 12:53:59 +0000 - fix: preserve `dep_name` for build script metadata (rust-lang/cargo#16494) - refactor(toml): clarify `to_dependency` for config patch (rust-lang/cargo#16492) - Add `--id` flag to `cargo report timings` and `cargo report rebuilds` (rust-lang/cargo#16490) - Display lockfile path in very verbose mode when blocking (rust-lang/cargo#16491) - fix(info): resolve underscore vs hyphen mismatch in schema lookup (rust-lang/cargo#16455) --- An extra submodule update right after <#150739> due to a relatively impactful nightly regression <rust-lang/cargo#16493>
rust-bors bot
added a commit
to rust-lang/rust
that referenced
this pull request
Jan 11, 2026
Update cargo submodule 5 commits in 8c133afcd5e0d69932fe11f5907683723f8d361d..6d1bd93c47f059ec1344cb31e68a2fb284cbc6b1 2026-01-09 03:50:15 +0000 to 2026-01-10 12:53:59 +0000 - fix: preserve `dep_name` for build script metadata (rust-lang/cargo#16494) - refactor(toml): clarify `to_dependency` for config patch (rust-lang/cargo#16492) - Add `--id` flag to `cargo report timings` and `cargo report rebuilds` (rust-lang/cargo#16490) - Display lockfile path in very verbose mode when blocking (rust-lang/cargo#16491) - fix(info): resolve underscore vs hyphen mismatch in schema lookup (rust-lang/cargo#16455) --- An extra submodule update right after <#150739> due to a relatively impactful nightly regression <rust-lang/cargo#16493>
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jan 12, 2026
Update cargo submodule 5 commits in 8c133afcd5e0d69932fe11f5907683723f8d361d..6d1bd93c47f059ec1344cb31e68a2fb284cbc6b1 2026-01-09 03:50:15 +0000 to 2026-01-10 12:53:59 +0000 - fix: preserve `dep_name` for build script metadata (rust-lang/cargo#16494) - refactor(toml): clarify `to_dependency` for config patch (rust-lang/cargo#16492) - Add `--id` flag to `cargo report timings` and `cargo report rebuilds` (rust-lang/cargo#16490) - Display lockfile path in very verbose mode when blocking (rust-lang/cargo#16491) - fix(info): resolve underscore vs hyphen mismatch in schema lookup (rust-lang/cargo#16455) --- An extra submodule update right after <rust-lang/rust#150739> due to a relatively impactful nightly regression <rust-lang/cargo#16493>
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jan 12, 2026
Update cargo submodule 5 commits in 8c133afcd5e0d69932fe11f5907683723f8d361d..6d1bd93c47f059ec1344cb31e68a2fb284cbc6b1 2026-01-09 03:50:15 +0000 to 2026-01-10 12:53:59 +0000 - fix: preserve `dep_name` for build script metadata (rust-lang/cargo#16494) - refactor(toml): clarify `to_dependency` for config patch (rust-lang/cargo#16492) - Add `--id` flag to `cargo report timings` and `cargo report rebuilds` (rust-lang/cargo#16490) - Display lockfile path in very verbose mode when blocking (rust-lang/cargo#16491) - fix(info): resolve underscore vs hyphen mismatch in schema lookup (rust-lang/cargo#16455) --- An extra submodule update right after <rust-lang/rust#150739> due to a relatively impactful nightly regression <rust-lang/cargo#16493>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16472
This diff adds the ability to specify a session ID when running
cargo report timingsandcargo report rebuilds. Previously, these commands always reported on the most recent build session. Now users can inspect any previous session by passing--id <SESSION_ID>.