Skip to content

Conversation

@weihanglo
Copy link
Member

5 commits in 8c133afcd5e0d69932fe11f5907683723f8d361d..6d1bd93c47f059ec1344cb31e68a2fb284cbc6b1
2026-01-09 03:50:15 +0000 to 2026-01-10 12:53:59 +0000


An extra submodule update right after #150739 due to a relatively impactful nightly regression rust-lang/cargo#16493

@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2026

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2026

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2026

⚠️ Warning ⚠️

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 10, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 10, 2026

📌 Commit 8332887 has been approved by weihanglo

It is now in the queue for this repository.

@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2026
@Zalathar
Copy link
Member

Scheduling: Bumping this from p=1 to p=5 to encourage interleaving rollups with non-rollups.

@bors p=5

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Jan 11, 2026
Update cargo submodule

5 commits in 8c133afcd5e0d69932fe11f5907683723f8d361d..6d1bd93c47f059ec1344cb31e68a2fb284cbc6b1
2026-01-09 03:50:15 +0000 to 2026-01-10 12:53:59 +0000
- fix: preserve `dep_name` for build script metadata  (rust-lang/cargo#16494)
- refactor(toml): clarify `to_dependency` for config patch (rust-lang/cargo#16492)
- Add `--id` flag to `cargo report timings` and `cargo report rebuilds` (rust-lang/cargo#16490)
- Display lockfile path in very verbose mode when blocking (rust-lang/cargo#16491)
- fix(info): resolve underscore vs hyphen mismatch in schema lookup (rust-lang/cargo#16455)

---

An extra submodule update right after <#150739> due to a relatively impactful nightly regression <rust-lang/cargo#16493>
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@rust-bors rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 11, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 11, 2026

💔 Test for 8c525e6 failed: CI. Failed jobs:

@Zalathar
Copy link
Member

@bors p=1
@bors try jobs=dist-i586-gnu-i586-i686-musl

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Jan 11, 2026
Update cargo submodule

try-job: dist-i586-gnu-i586-i686-musl
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 11, 2026

☀️ Try build successful (CI)
Build commit: 46abfb8 (46abfb88d2405c3844cdf01a20dd7e2e536ae38f, parent: 9bc8b40bc314b74e1d5e5ab21a0df39c55a34806)

@Zalathar
Copy link
Member

@bors retry

@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added the merged-by-bors This PR was explicitly merged by bors. label Jan 11, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 11, 2026

☀️ Test successful - CI
Approved by: weihanglo
Pushing 7c41ee6 to main...

@rust-bors rust-bors bot merged commit 7c41ee6 into rust-lang:main Jan 11, 2026
13 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 11, 2026
@rustbot rustbot added this to the 1.94.0 milestone Jan 11, 2026
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 1279939 (parent) -> 7c41ee6 (this PR)

Test differences

Show 14 test diffs

Stage 2

  • build_script::with_patch: [missing] -> pass (J0)
  • cargo_info::crate_name_normalization_from_hyphen_to_underscore::case: [missing] -> pass (J0)
  • cargo_info::crate_name_normalization_from_underscore_to_hyphen::case: [missing] -> pass (J0)
  • cargo_report_rebuilds::invalid_session_id_format: [missing] -> pass (J0)
  • cargo_report_rebuilds::session_id_not_found: [missing] -> pass (J0)
  • cargo_report_rebuilds::with_session_id: [missing] -> pass (J0)
  • cargo_report_timings::invalid_session_id_format: [missing] -> pass (J0)
  • cargo_report_timings::session_id_not_found: [missing] -> pass (J0)
  • cargo_report_timings::with_session_id: [missing] -> pass (J0)
  • concurrent::verbose_file_lock_blocking: [missing] -> pass (J0)

Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 7c41ee66db9d08e3989858acaefa1c72a6a88518 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 2040.3s -> 1496.1s (-26.7%)
  2. x86_64-gnu-llvm-20: 5034.5s -> 4283.7s (-14.9%)
  3. i686-gnu-2: 5950.4s -> 5072.8s (-14.7%)
  4. x86_64-rust-for-linux: 3029.0s -> 2655.0s (-12.3%)
  5. dist-aarch64-apple: 7183.5s -> 6316.9s (-12.1%)
  6. i686-gnu-1: 8388.2s -> 7379.5s (-12.0%)
  7. dist-aarch64-llvm-mingw: 6145.9s -> 5428.8s (-11.7%)
  8. i686-gnu-nopt-1: 8209.1s -> 7278.0s (-11.3%)
  9. x86_64-gnu-debug: 7481.1s -> 6671.3s (-10.8%)
  10. aarch64-apple: 9239.2s -> 10208.2s (+10.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7c41ee6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.8% [-3.3%, -2.4%] 2
All ❌✅ (primary) - - 0

Cycles

Results (primary -2.2%, secondary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.6% [4.1%, 5.2%] 2
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
-6.0% [-6.0%, -6.0%] 1
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.69s -> 473.762s (0.02%)
Artifact size: 391.41 MiB -> 391.43 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants