Resolve nostarch comments #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carols10cents
force-pushed
the
resolve-nostarch-comments
branch
from
5ba3d7e to
de900ff
Compare
|
Ok, I consider this done now, and ready for any comments! I am planning on merging this and sending a new version of chapters 1 and 2 to nostarch on Friday afternoon ET. |
carols10cents
force-pushed
the
resolve-nostarch-comments
branch
from
c407a0a to
13febc4
Compare
So that we can make sure we're consistent.
With a few further small tweaks.
I think this is a bug in the markdown implementation; I would expect this to only happen if there was an empty line before the line starting with "#.". Will report, but I just reworded it so the numbers don't land that way for now.
carols10cents
force-pushed
the
resolve-nostarch-comments
branch
from
13febc4 to
2588389
Compare
AbrarNitk
pushed a commit
to FifthTry/rust-book
that referenced
this pull request
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, this PR I am planning on merging, after leaving it open a few days for comments if anyone wants to take a look.
Also I'm not quite done yet but wanted to open the PR. Left to do before I would consider this "done":
Resultto the end of the tutorialAlso I'm NOT addressing things in this PR that I want to address more systemically, like:
Need a "link to in-prose text URL" conversion script #185)filenames (Where appropriate, put "Filename: whatever" before code blocks #190)italics instead of single quotes for new terms (Prefer italics over single quotes when introducing new terms #191)