Skip to content

100. seems to be interpreted as an ordered list #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ykomatsu opened this issue Aug 18, 2016 · 4 comments
Closed

100. seems to be interpreted as an ordered list #199

ykomatsu opened this issue Aug 18, 2016 · 4 comments
Labels
blocked upstream Blocked on a change that needs to happen in a different repo first Bug has workaround Online only
Milestone

Comments

@ykomatsu
Copy link
Contributor

ykomatsu commented Aug 18, 2016

https://raw.githubusercontent.com/rust-lang/book/master/nostarch/chapter02.md

You should get different random numbers, and they should all be between 1 and
100. Great job! Next up: comparing our guess to the secret number.

100. seems to be interpreted as an ordered list.

http://rust-lang.github.io/book/ch02-00-guessing-game-tutorial.html

CommonMark Spec says:

In CommonMark, a list can interrupt a paragraph.

http://spec.commonmark.org/0.26/#example-264

In order to solve of unwanted lists in paragraphs with hard-wrapped numerals, we allow only lists starting with 1 to interrupt paragraphs.

http://spec.commonmark.org/0.26/#example-265

It seems to be an issue in google/pulldown-cmark.

http://spec.commonmark.org/dingus/?text=You%20should%20get%20different%20random%20numbers%2C%20and%20they%20should%20all%20be%20between%201%20and%0A100.%20Great%20job!%20Next%20up%3A%20comparing%20our%20guess%20to%20the%20secret%20number.

@azerupi
Copy link
Contributor

azerupi commented Aug 18, 2016

Pulldown-cmark is still on an older version of the spec. I have opened a PR as an effort to update it, but I need help to fix the failing tests.

In the mean time, I guess the fix would be to avoid a line break before a numeral followed by a point.

@carols10cents
Copy link
Member

Yeaahhh I noticed this recently and I have a commit in #192 that rewords so the lines don't end up that way. That PR will be merged on Friday, but thank you for filing a bug to remind me to follow up on it!! 📂 👣

I doubt I'll have time to help with the pulldown-cmark tests :-/

@carols10cents carols10cents added Bug blocked upstream Blocked on a change that needs to happen in a different repo first has workaround labels Aug 18, 2016
@carols10cents carols10cents added this to the all milestone Aug 27, 2016
carols10cents added a commit that referenced this issue Feb 25, 2017
carols10cents added a commit that referenced this issue Dec 6, 2017
carols10cents added a commit that referenced this issue Apr 4, 2018
@vbo
Copy link

vbo commented Apr 14, 2018

Same issue seems to break layout on this page: https://doc.rust-lang.org/book/second-edition/ch15-05-interior-mutability.html (we will in Chapter 19. -> we will in Chapter <ol start="19">)

@steveklabnik
Copy link
Member

I believe this has been addressed to the best of our abilities. If you see a similar issue, please file a new bug, thank you!

AbrarNitk pushed a commit to FifthTry/rust-book that referenced this issue Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked upstream Blocked on a change that needs to happen in a different repo first Bug has workaround Online only
Projects
None yet
Development

No branches or pull requests

5 participants