Add inline-asm build to CI, fix build #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disasm
force-pushed
the
check-inline-asm
branch
3 times, most recently
from
b5574a2 to
7f53427
Compare
Disasm
force-pushed
the
check-inline-asm
branch
from
7f53427 to
0b28f19
Compare
|
bors r=dkhayes117 |
romancardenas
pushed a commit
that referenced
this pull request
Nov 17, 2023
91: Don't use a random hash ident, instead use the crate prefixed symbol r=almindor a=MabezDev This is what cortex-m land is doing. This was initially discovered to be an issue when implementing unwinding in riscv probe-rs, the dwarf info shows the hashed symbol name which is a bit weird, this makes it more clear what the symbol actually is. Co-authored-by: Scott Mabin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#86 introduced new
asm!syntax which is enabled with theinline-asmfeature. However, it doesn't work with current nightly sinceasm_constunstable feature is not enabled. This PR fixes the problem and adds automatic checks to CI.