Skip to content

Conversation

@dtwood
Copy link
Collaborator

@dtwood dtwood commented Dec 13, 2018

No description provided.

@dtwood dtwood force-pushed the ethernet-draft branch 3 times, most recently from 4c08f11 to 9546379 Compare December 14, 2018 20:10
@thejpster
Copy link
Member

Hey! How's this one coming along?

@dtwood
Copy link
Collaborator Author

dtwood commented Feb 6, 2019

Still very much a work in progress, but it does work! Next steps are I think to find some time to sit down, and simplify / tidy this as much as possible. Then it should be ready for at least a first attempt at reviewing.

Independently, I still need to have a think about rust-embedded/wg#278 (comment), and whether I want to write up some ideas for how that should be integrated, the intial draft in https://github.com/dtwood/svd2rust/tree/ephy and https://github.com/dtwood/svd2rust/tree/edes breaks the rest of svd2rust. And I think there should probably be some sort of template support for weirder cases like these, so that the they can stay out of tree and the templates provided along with the libraries instead. Maybe at some point I'll find some time to type that all up somewhere 🙂

@dtwood
Copy link
Collaborator Author

dtwood commented May 28, 2019

If you find some time, I think this now in a state where I'm mostly happy with it, and would be ready for a first pass review. Things that are still outstanding are to push the revision of vcell forwards to compile on stable (currently blocked on a release including japaric/vcell#4), and to add an 'ethernet' feature flag, that will pull in smoltcp.

One other thought is whether this driver should actually be a separate crate (tm4c129x-eth), like the https://github.com/stm32-rs/stm32-eth crate?

@thejpster
Copy link
Member

thejpster commented May 29, 2019 via email

pub use tm4c_hal::time;

pub mod edes;
mod edes_old;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's edes_old for?

@thejpster
Copy link
Member

Shall we try and push this one over the line? Ethernet support might be useful for another project I'm working on...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants