Add RubyVM::AbstractSyntaxTree #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znz
reviewed
Jun 21, 2020
pocke
changed the title
znz
reviewed
Jul 7, 2020
| @raise SyntaxError string が Ruby のコードとして正しくない場合に発生します。 | ||
|
|
||
| #@samplecode | ||
| # => (SCOPE@1:0-1:50 |
There was a problem hiding this comment.
出力例しかないので、 IO などの例にあるように File.write と組み合わせた例にしておくと良さそうです。
There was a problem hiding this comment.
何故かコードを貼り付けるのを忘れていたみたいです 💦
0dfb3db
|
|
||
| @param proc Procもしくはメソッドオブジェクトを指定します。 | ||
|
|
||
| #@samplecode |
There was a problem hiding this comment.
irb で試すと Errno::ENOENT になるようなので、 @raise を追加したり、サンプルコードに注意書きを追加すると良さそうです。
There was a problem hiding this comment.
RDoc の方で書かれていないのに @raise を足すべきか微妙だなと思ったのと、サンプルコード特有の問題ではなくて一般に起こりうる問題なので、本文に説明を足してみました。
|
|
||
| --- first_column -> Integer | ||
|
|
||
| ソースコード中で、self を表すテキストが最初に現れる列番号を返します。 |
There was a problem hiding this comment.
(fisrt|last)_(column|line) に説明を足しました 🙆♂️
|
|
||
| --- first_lineno -> Integer | ||
|
|
||
| ソースコード中で、self を表すテキストが最初に現れる行番号を返します。 |
|
|
||
| --- last_column -> Integer | ||
|
|
||
| ソースコード中で、self を表すテキストが最後に現れる列番号を返します。 |
There was a problem hiding this comment.
こちらも 0-origin でバイト単位という説明があると良さそうです。
|
|
||
| --- last_lineno -> Integer | ||
|
|
||
| ソースコード中で、self を表すテキストが最後に現れる行番号を返します。 |
znz
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1977