Skip to content

Add section on merging keyword arguments #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Add section on merging keyword arguments #948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions README.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3167,6 +3167,19 @@ def some_method(bar: false)
end
----

=== Merging Keyword Arguments [[merging-keyword-arguments]]

When passing an existing hash as keyword arguments, add additional arguments directly rather than using `merge`.
Copy link
Collaborator

@bbatsov bbatsov Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to extend this rationale a bit, as it's not clear why this is preferable, but I'll merge this as is for now.


[source,ruby]
----
# bad
some_method(**opts.merge(foo: true))

# good
some_method(**opts, foo: true)
----

=== Arguments Forwarding [[arguments-forwarding]]

Use Ruby 2.7's arguments forwarding.
Expand Down