Skip to content

Conversation

@dvandersluis
Copy link
Member

Adds a guideline for rubocop/rubocop#13252.

# bad
some_method(**opts.merge(foo: true))

# good
some_method(**opts, foo: true)

@bbatsov bbatsov merged commit 756129b into rubocop:master Oct 16, 2024
3 checks passed

=== Merging Keyword Arguments [[merging-keyword-arguments]]

When passing an existing hash as keyword arguments, add additional arguments directly rather than using `merge`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to extend this rationale a bit, as it's not clear why this is preferable, but I'll merge this as is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants