-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buildx bake with goss test runner orchestration #718
Conversation
Add entrypoint setting to tests
Fix tests on WAML and improve logging
Clean up dockerfiles
…lines [DNM] Test separating image lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I enjoy they way this is structured. I was able to run build locally.
I can see how you thought about how the actions are structured using composite actions and it is much easier for me to follow. So nice to see how fast certain actions finish.
This is a significant step towards simplifying development! Long term I hope that preview and regular builds can be the same bake. I get how for now this is not possible.
Closes #714
Closes #717
Apologies in advance for the sheer size of this PR. Unfortunately, I didn't see a great way to break up the build changes without putting the repo in an awkward state.
Adds
docker buildx bake
for build orchestration.bake
files are broken up intodocker-bake.hcl
(Release image builds),docker-bake.preview.hcl
(Preview image builds), andcontent/docker-bake.hcl
(Content image builds). All existing image builds have been recreated inbake
. By implementingbake
, we should resolve sanity issues around image layering in CI since base image artifacts are explicitly passed to downstream image builds and will not pull from a registry../tools/test_bake_artifacts.py
) for running tests based off a generated build plan frombake
.just
targets for building and testingbake
builds.Changes
run_tests.sh
scripts for compatibility with new build/test flow.goss.yaml
files across several projects, mostly increasing timeouts on slow elements likejupyter
tests.Removes
build-content.yaml
,build-prerelease.yaml
,build-release.yaml
,build-workbench-aml.yaml
, andbuild-workbench-gcw.yaml
.docker-compose.test.yml
files in product directories. These have been replaced with the./tools/test_bake_artifacts.py
script.