-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker buildx bake experiment for builds #705
Conversation
The action that matters is |
This is interesting, I hadn't heard of |
FWIW we did a bunch of testing with https://github.com/rstudio/connect/issues/23961#issuecomment-1613775719 |
We weren't previously using caching for these builds so I'm not concerned with anything like that at the moment. Thanks for the heads up though! |
a90f046
to
8174e77
Compare
Use a standard runner for content images
Provide a buildx config for GHA Unify test sleep behavior of Workbench images
Merged in #718 |
I have attempted to avoid any tricks or advanced features of hcl within bake. There are many optimizations we could make from here. Most importantly this does not break anything!
Docker buildx bake has several advantages:
This PR builds everything within a single runner and no complex github action workflows. All is captured within the
docker-bake.hcl
. It is possible to easily exclude certain builds etc and only build certain ones.This builds:
- product-base
- product-base-pro
- connect
- connect-content-init
- package-manager
- r-session-complete
- workbench
- workbench-for-google-cloud-workstations
- workbench-for-microsoft-azure-ml