Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GenericSubscription's handle_message signature #373

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Update GenericSubscription's handle_message signature #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rosbag2_transport/src/rosbag2_transport/generic_subscription.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,15 @@ std::shared_ptr<rmw_serialized_message_t> GenericSubscription::create_serialized
}

void GenericSubscription::handle_message(
std::shared_ptr<void> & message, const rmw_message_info_t & message_info)
std::shared_ptr<void> & message, const rclcpp::MessageInfo & message_info)
{
(void) message_info;
auto typed_message = std::static_pointer_cast<rmw_serialized_message_t>(message);
callback_(typed_message);
}

void GenericSubscription::handle_loaned_message(
void * message, const rmw_message_info_t & message_info)
void * message, const rclcpp::MessageInfo & message_info)
{
(void) message;
(void) message_info;
Expand Down
4 changes: 2 additions & 2 deletions rosbag2_transport/src/rosbag2_transport/generic_subscription.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ class GenericSubscription : public rclcpp::SubscriptionBase
std::shared_ptr<rmw_serialized_message_t> create_serialized_message() override;

void handle_message(
std::shared_ptr<void> & message, const rmw_message_info_t & message_info) override;
std::shared_ptr<void> & message, const rclcpp::MessageInfo & message_info) override;

void handle_loaned_message(
void * loaned_message, const rmw_message_info_t & message_info) override;
void * loaned_message, const rclcpp::MessageInfo & message_info) override;

// Same as return_serialized_message() as the subscription is to serialized_messages only
void return_message(std::shared_ptr<void> & message) override;
Expand Down