Skip to content

Commit

Permalink
Update GenericSubscription's handle_message signature (#373)
Browse files Browse the repository at this point in the history
Signed-off-by: Emerson Knapp <[email protected]>
  • Loading branch information
emersonknapp authored Apr 14, 2020
1 parent 0cd9d51 commit f03a6ce
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,15 @@ std::shared_ptr<rmw_serialized_message_t> GenericSubscription::create_serialized
}

void GenericSubscription::handle_message(
std::shared_ptr<void> & message, const rmw_message_info_t & message_info)
std::shared_ptr<void> & message, const rclcpp::MessageInfo & message_info)
{
(void) message_info;
auto typed_message = std::static_pointer_cast<rmw_serialized_message_t>(message);
callback_(typed_message);
}

void GenericSubscription::handle_loaned_message(
void * message, const rmw_message_info_t & message_info)
void * message, const rclcpp::MessageInfo & message_info)
{
(void) message;
(void) message_info;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ class GenericSubscription : public rclcpp::SubscriptionBase
std::shared_ptr<rmw_serialized_message_t> create_serialized_message() override;

void handle_message(
std::shared_ptr<void> & message, const rmw_message_info_t & message_info) override;
std::shared_ptr<void> & message, const rclcpp::MessageInfo & message_info) override;

void handle_loaned_message(
void * loaned_message, const rmw_message_info_t & message_info) override;
void * loaned_message, const rclcpp::MessageInfo & message_info) override;

// Same as return_serialized_message() as the subscription is to serialized_messages only
void return_message(std::shared_ptr<void> & message) override;
Expand Down

0 comments on commit f03a6ce

Please sign in to comment.