Skip to content

Update Ament-CMake-Documentation.rst #5639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update Ament-CMake-Documentation.rst #5639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/How-To-Guides/Ament-CMake-Documentation.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ The basic outline of the ``CMakeLists.txt`` of an ament package contains:

.. code-block:: cmake

cmake_minimum_required(VERSION 3.8)
cmake_minimum_required(VERSION 3.20)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are targeting humble I think the version is right here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right that this version is fine for Humble.

REP 2000 lists a bunch of CMake versions for Humble for all the target platforms, and they're all definitely > 3.8: https://www.ros.org/reps/rep-2000.html#humble-hawksbill-may-2022-may-2027. However, it's not that CMake 3.8 is necessarily deprecated: I believe it's actually about declaring a minimum version that's too low (e.g., 3.8) with a newer version of CMake, but Humble (Ubuntu 22.04) has an older version of CMake.

Then I'd just leave this as-is.

project(my_project)

ament_package()
Expand Down