Update Ament-CMake-Documentation.rst #5639
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmake version <3.10 is deprecated Signed-off-by: mosfet80 <[email protected]>
ahcorde
reviewed
May 20, 2025
| @@ -30,7 +30,7 @@ The basic outline of the ``CMakeLists.txt`` of an ament package contains: | |||
|
|
|||
| .. code-block:: cmake | |||
|
|
|||
| cmake_minimum_required(VERSION 3.8) | |||
| cmake_minimum_required(VERSION 3.20) | |||
There was a problem hiding this comment.
you are targeting humble I think the version is right here
There was a problem hiding this comment.
I think you're right that this version is fine for Humble.
REP 2000 lists a bunch of CMake versions for Humble for all the target platforms, and they're all definitely > 3.8: https://www.ros.org/reps/rep-2000.html#humble-hawksbill-may-2022-may-2027. However, it's not that CMake 3.8 is necessarily deprecated: I believe it's actually about declaring a minimum version that's too low (e.g., 3.8) with a newer version of CMake, but Humble (Ubuntu 22.04) has an older version of CMake.
Then I'd just leave this as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cmake version <3.10 is deprecated
Did you use Generative AI?
Additional Information