Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows-Install-Binary.rst #4054

Closed
wants to merge 3 commits into from
Closed

Conversation

ashfaq92
Copy link
Contributor

@ashfaq92 ashfaq92 commented Dec 7, 2023

Updated warning message: Clarified that the warning does not indicate issues with ROS2 installation, addressing potential confusion for beginners.

Updated warning message: Clarified that the warning does not indicate issues with ROS2 installation, addressing potential confusion for beginners.

Signed-off-by: Muhammad Ashfaq <[email protected]>
@ashfaq92
Copy link
Contributor Author

ashfaq92 commented Dec 7, 2023

Sorry, I pasted the sentence at wrong location.
The correct location was meant to be at line 51 after the text:

It is normal that the previous command, if nothing else went wrong, outputs "The system cannot find the path specified." exactly once.

So, this sentence becomes:

It is normal that the previous command, if nothing else went wrong, outputs "The system cannot find the path specified." exactly once. If you encounter a warning message similar to [rti_context_adds_cmake_module], feel free to ignore it. This warning does not indicate any issues with the ROS2 installation functionality.

source/Installation/Windows-Install-Binary.rst Outdated Show resolved Hide resolved
@@ -30,7 +30,9 @@ Downloading ROS 2

.. note::

There may be more than one binary download option which might cause the file name to differ.
There may be more than one binary download option which might cause the file name to differ.
If you encounter a warning message similar to ``[rti_context_adds_cmake_module]``, feel free to ignore it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the exact error message; at the very least it would be something like rti_connext_cmake_module. But I don't think we should put a warning in unless we know exactly what we are warning against. So let's find the exact error message and put that in.

ashfaq92 and others added 2 commits December 8, 2023 20:36
Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Muhammad Ashfaq <[email protected]>
Signed-off-by: Muhammad Ashfaq <[email protected]>
@@ -49,6 +49,8 @@ Start a command shell and source the ROS 2 setup file to set up the workspace:
call C:\dev\ros2_{DISTRO}\local_setup.bat

It is normal that the previous command, if nothing else went wrong, outputs "The system cannot find the path specified." exactly once.
If you encounter a warning message similar to ``[rti_context_adds_cmake_module]``, feel free to ignore it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not the correct error message. It should say something about connext.

@clalancette clalancette added the more-information-needed Further information is required label Dec 21, 2023
@clalancette
Copy link
Contributor

Since there has been no response here in over 2 weeks, I'm going to close this out. Please feel free to respond to my latest comments and reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-information-needed Further information is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants