[Jazzy] Improve error reporting by adding file locations to exceptions #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you be able to target the |
Signed-off-by: Roland Arsenault <[email protected]>
Signed-off-by: Roland Arsenault <[email protected]>
rolker
force-pushed
the
improve_error_reporting_jazzy
branch
from
0068b74 to
9f4149a
Compare
|
Opened a PR against rolling with the same commits. Should I leave this open to backport to Jazzy or is there another mechanism to do that? |
rolker
changed the title
|
We can close this for now. We have a tool that backports PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to pinpoint which launch file caused an exception, this patch intercepts exceptions and adds notes that help determine the source of the error.
This might help with #799 as well.