Skip to content

Version 0.4.0 #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Version 0.4.0 #343

merged 1 commit into from
Nov 7, 2023

Conversation

esteve
Copy link
Collaborator

@esteve esteve commented Nov 7, 2023

No description provided.

@esteve esteve requested review from jhdcs, maspe36 and nnmm November 7, 2023 14:07
@esteve
Copy link
Collaborator Author

esteve commented Nov 7, 2023

This is the text I'll use for the release:

Highlights for this release:

Thanks to all the contributors that made this release possible:

Fawdlstty @fawdlstty
Uwe Arzt @uwearzt
Luca Della Vedova @luca-della-vedova
Michael Grey @mxgrey
Sam Privett @maspe36
Carter Schultz @Carter12s

@jhdcs @nnmm @maspe36 @Carter12s @mxgrey @luca-della-vedova can you check that everyting is ok? Thanks.

@jhdcs
Copy link
Collaborator

jhdcs commented Nov 7, 2023

The changes you've made appear to be correct, but the build is currently failing. I don't think it's due to this PR, but I feel like we should figure out what the issue is and fix it before we push out the new version...

@esteve
Copy link
Collaborator Author

esteve commented Nov 7, 2023

@jhdcs I think it's caused by a change in the traits in rosidl_runtime_rs. I've bumped the depepdency version for it and hopefully Cargo won't use the version that's in crates.io

@maspe36
Copy link
Collaborator

maspe36 commented Nov 7, 2023

Do we not want to highlight the addition of the time source API? Other than that LGTM, will approve once the builds passing

@esteve
Copy link
Collaborator Author

esteve commented Nov 7, 2023

Do we not want to highlight the addition of the time source API? Other than that LGTM, will approve once the builds passing

It's there:

Add time source and clock API to nodes (#325)

Or do you mean something else?

@maspe36
Copy link
Collaborator

maspe36 commented Nov 7, 2023

Oh, whoops, my mistake. Apologies, it's quite early on the west coast 😁

Signed-off-by: Esteve Fernandez <[email protected]>
@esteve
Copy link
Collaborator Author

esteve commented Nov 7, 2023

@jhdcs it's fixed now

@jhdcs
Copy link
Collaborator

jhdcs commented Nov 7, 2023

Looks good to me!

Once again, thank you very much to everyone who contributed! This would not have been possible without you!

@esteve esteve merged commit e7065a7 into main Nov 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the bump-0.4.0 branch November 7, 2023 15:38
esteve added a commit that referenced this pull request Nov 7, 2023
@esteve esteve mentioned this pull request Nov 7, 2023
esteve added a commit that referenced this pull request Nov 7, 2023
esteve added a commit that referenced this pull request Nov 7, 2023
* Revert "Version 0.4.0 (#343)"

This reverts commit e7065a7.

* Vendorize rosgraph_msgs

Signed-off-by: Esteve Fernandez <[email protected]>

* Fix module path

* Fix format

---------

Signed-off-by: Esteve Fernandez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants