-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix fetching kickstarts from OEMDRV #6222
base: main
Are you sure you want to change the base?
Conversation
See dracut/kickstart-genrules.sh for fetching kickstarts broken functionality. fix Bug 2346192
|
OEMDRV is expected to be on different device than what is used for installation. I think this change is more RFE than a fix. |
I have a bad feeling about this change. You are basically returning this regression back Even when it's on limited cases but still. Also the change will result in more fragile code as we need to keep an eye how is the root specified everywhere else where we may mount the partition. |
Anyway, it's on the same installation media. |
The change is absolutely safe and is real, the only reasonable fix (I couldn't find another one). #2863 issue can only happen if you pass the installation device to Nothing bad can happen if you pass the partition unambiguously: via |
You don't have to worry about it as it's all normalized here: anaconda/dracut/anaconda-lib.sh Lines 209 to 212 in dfcc09a
|
See dracut/kickstart-genrules.sh for fetching kickstarts broken functionality:
The
OEMDRV
partition couldn't be mounted because the whole installation media disk is always mounted before asiso9660
first, blocking all the other mounts.This patch allows workaround the problem by unambiguously specifying cmdline ISO partition by file directly, e.g.:
inst.stage2=hd:/dev/disk/by-partlabel/ISO9660
instead of default specifying by LABEL, e.g.:
inst.stage2=hd:LABEL=Fedora-SB-ostree-x86_64-41
See 301a09d for details.
Fixes Bug 2346192.
Related Lorax issue:
weldr/lorax#1451
@poncovka @bcl