Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ks.cfg can't be fetched from any non-ISO partition of installation media (ESP, OEMDRV, etc.) #1284

Open
bam80 opened this issue Mar 4, 2025 · 0 comments

Comments

@bam80
Copy link

bam80 commented Mar 4, 2025

bootTreePipeline.KernelOpts = []string{fmt.Sprintf("inst.stage2=hd:LABEL=%s", img.ISOLabel), fmt.Sprintf("inst.ks=hd:LABEL=%s:%s", img.ISOLabel, img.Kickstart.Path)}

The problem here is specifying ISO filesystem of the hybrid ISO image by LABEL leads to ambiguity,
as the same LABEL applies to both a whole disk and also to it's first partition,
see here for details:

# setup loopback device and partitions within
$ sudo losetup /dev/loop0 --partscan Fedora-Silverblue-ostree-x86_64-41-1.4.iso

# output properties of the block devices
$ lsblk /dev/loop0 -o NAME,UUID,LABEL,PARTLABEL
NAME      UUID                                 LABEL                      PARTLABEL
loop0     2024-10-24-14-37-30-00               Fedora-SB-ostree-x86_64-41 
├─loop0p1 2024-10-24-14-37-30-00               Fedora-SB-ostree-x86_64-41 ISO9660
└─loop0p2 BA81-F12E                            ANACONDA                   Appended2

This results the whole disk gets mounted first as ISO, blocking other partitions mounts, which might be needed to fetch ks.cfg, etc.

Proposed solution:

  1. apply fix fetching kickstarts from OEMDRV rhinstaller/anaconda#6222
  2. as discussed, change inst.stage2 option from:
    inst.stage2=hd:LABEL=<ISO label>
    to:
    inst.stage2=hd:/dev/disk/by-partlabel/ISO9660
    Or find a way to get a PARTLABEL from the image's partition table and use it here instead of the hardcoded ISO9660.

Original Anaconda report:
https://bugzilla.redhat.com/show_bug.cgi?id=2346192
Lorax:
weldr/lorax#1451

@bam80 bam80 changed the title regression: ks.cfg can't be fetched from any non-ISO partition of installation media (ESP, OEMDRV, etc.) ks.cfg can't be fetched from any non-ISO partition of installation media (ESP, OEMDRV, etc.) Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant