-
Notifications
You must be signed in to change notification settings - Fork 457
Replace anyhow
with thiserror
in libraries
#1845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
…3487) <!-- Open the PR up as a draft until you feel it is ready for a proper review. Do not make PR:s from your own `main` branch, as that makes it difficult for reviewers to add their own fixes. Add any improvements to the branch as new commits to make it easier for reviewers to follow the progress. All commits will be squashed to a single commit once the PR is merged into `main`. Make sure you mention any issues that this PR closes in the description, as well as any other related issues. To get an auto-generated PR description you can put "copilot:summary" or "copilot:walkthrough" anywhere. --> ### What - Improves Use of `thiserror` in crates([#1845](#1845)) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{ pr.number }}) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }}) - [Docs preview](https://rerun.io/preview/{{ pr.commit }}/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/{{ pr.commit }}/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
…4759) ### What * part of #1845 Started also removing it the file resolver/reloader but it's super tedious and makes errors worse since during include resolve we often want to stack errors. We can revisit that if we ever move out the shader reloading or when we tackle * #2664 but otherwise I don't think it's worth it. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4759/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4759/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4759/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4759) - [Docs preview](https://rerun.io/preview/79d6075baae6651555be0431005e07817440c3b5/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/79d6075baae6651555be0431005e07817440c3b5/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
We should do this in |
I have replaced it in Edit: check #9579 |
We have been too liberal of our use of
anyhow
. For anypub
function in our libraries, we should be usingthiserror
instead ofanyhow
, to get more type safety and explicitness of what can go wrong.Internal use of
anyhow
in a crate is less bad, but would also be good to change tothiserror
.anyhow
should mostly be used in high-level crates (binaries) to easily summarize errors coming from many different places without having to create too many errorenum
sThe text was updated successfully, but these errors were encountered: