Use thiserror in re_renderer everywhere except shader file reloading#4759
Merged
Use thiserror in re_renderer everywhere except shader file reloading#4759
Conversation
teh-cmc
approved these changes
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
anyhowwiththiserrorin libraries #1845Started also removing it the file resolver/reloader but it's super tedious and makes errors worse since during include resolve we often want to stack errors. We can revisit that if we ever move out the shader reloading or when we tackle
naga_oilinstead of custom import handling #2664but otherwise I don't think it's worth it.
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io