Skip to content

Use thiserror in re_renderer everywhere except shader file reloading#4759

Merged
Wumpf merged 4 commits intomainfrom
andreas/thiserror-for-re_renderer
Jan 10, 2024
Merged

Use thiserror in re_renderer everywhere except shader file reloading#4759
Wumpf merged 4 commits intomainfrom
andreas/thiserror-for-re_renderer

Conversation

@Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 9, 2024

What

Started also removing it the file resolver/reloader but it's super tedious and makes errors worse since during include resolve we often want to stack errors. We can revisit that if we ever move out the shader reloading or when we tackle

but otherwise I don't think it's worth it.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added 🔺 re_renderer rendering, graphics, GPU 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 9, 2024
@teh-cmc teh-cmc self-requested a review January 10, 2024 07:44
@Wumpf Wumpf merged commit 09a20a4 into main Jan 10, 2024
@Wumpf Wumpf deleted the andreas/thiserror-for-re_renderer branch January 10, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude from changelog PRs with this won't show up in CHANGELOG.md 🔺 re_renderer rendering, graphics, GPU 🚜 refactor Change the code, not the functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants