-
Notifications
You must be signed in to change notification settings - Fork 459
Converting anyhow
to this-error
for re_renderer Renderer::draw
#3487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…<()>' to 'Result<(), DrawRendererError>'
anyhow
to this-error
in High-level Cratesanyhow
to this-error
for re_renderer Renderer::draw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing!
Can you check if we can replace the anyhow based QueueableDrawDataError::DrawError
variant already now? If not we can punt on that, but it would create a weird name-clash (unclear what's the difference between QueueableDrawDataError::DrawError
and QueueableDrawDataError::DrawRenderer
). But I think this can be replaced now (see comment)
CI is having issues right now with PRs from forks, looking into getting some coverage
CI is sadly a lost cause at the moment, only PRs from inside the repo work correctly right now. I'll run some tests locally later. See #1994. We'll look into that soon'ish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks!
counter checked locally for any compilation issues etc. since our ci still doesn't work well with forked repos (we'll look into this soonish) |
What
thiserror
in crates(#1845)Checklist