Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Press Tab twice to focus on the upload button #520

Closed
wants to merge 4 commits into from
Closed

fix:Press Tab twice to focus on the upload button #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01ad6a9
fix:Press Tab twice to focus on the upload button
Nov 16, 2023
3946417
restore code style
Nov 16, 2023
9aee6ed
restore code style
Nov 16, 2023
c08c679
test: add some test case
Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/AjaxUploader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,6 @@ class AjaxUploader extends Component<UploadProps> {
onMouseLeave,
onDrop: this.onFileDrop,
onDragOver: this.onFileDrop,
tabIndex: '0',
};
return (
<Tag {...events} className={cls} role="button" style={style}>
Expand Down
5 changes: 5 additions & 0 deletions tests/uploader.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,4 +865,9 @@ describe('uploader', () => {
expect(wrapper.find('.bamboo-input').props().style.color).toEqual('red');
expect(wrapper.find('input').props().style.display).toBe('none');
});

it('the upload button wrapper span does not have the tabIndex attribute', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test case here should verify the number of times to focus.

const wrapper = mount(<Uploader />);
expect(wrapper.find('.rc-upload').props().tabIndex).toBe(undefined);
});
});