fix:Press Tab twice to focus on the upload button #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #520 +/- ##
=======================================
Coverage 87.10% 87.10%
=======================================
Files 6 6
Lines 256 256
Branches 63 63
=======================================
Hits 223 223
Misses 33 33 ☔ View full report in Codecov by Sentry. |
|
Please add some test case for it. |
have updated |
yoyo837
reviewed
Nov 17, 2023
| @@ -865,4 +865,9 @@ describe('uploader', () => { | |||
| expect(wrapper.find('.bamboo-input').props().style.color).toEqual('red'); | |||
| expect(wrapper.find('input').props().style.display).toBe('none'); | |||
| }); | |||
|
|
|||
| it('the upload button wrapper span does not have the tabIndex attribute', () => { | |||
There was a problem hiding this comment.
I think the test case here should verify the number of times to focus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the upload button wrapper span has the tabIndex attribute, pressing the tab key will first focus on the span element, and then pressing tab again will focus on the button element.I removed span tabIndex attribute. issue link 45922