fix advanced editor not saving correctly

[RyanCoulsonCA]

Related Item(s)

#312

Changes

• This PR fixes an issue where changes in the advanced editor weren't saving correctly.
• This PR also removes the redundant save button at the bottom of the advanced editor.

Notes

It doesn't seem like the JSON is being validated when you swap between tabs. I'm going to create a new issue for this.

Testing

Steps:

1. Go to the Editor
2. Load a product, click Next, select a slide on the left.
3. Select the "Advanced" tab and make any change. Ensure that changes are being saved correctly.

---

This change is 

[github-actions]

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/fix-312

[yileifeng]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

[dnlnashed]

Works good! Just noticed some things that are probably unrelated to this issue and can be made into a new one if needed

• When removing a panel using the advanced editor, if you click on the panel side that's been removed the slide editor ends up breaking
• After using the "Reset Changes" button the button still appears. Clicking it again removes everything from the editor.
• This one might be intentional, but removing the whole config in the advanced editor does not get saved.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

[RyanCoulsonCA]

Nice finds. I'll spin up a new issue for the first one because I haven't been able to find a great way to fix this one.

I can't seem to replicate the second one. Does the button stick around permanently after you've clicked it the first time? When I click the button, I see that it briefly pops up again after reloading but it disappears faster than I can click it again.

For the last one, I'm not sure how Storylines even reacts to a slide with no panels. It's probably best we don't allow the user to remove the whole config... for now we'll say this is intentional, but maybe we should add a warning message.

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

[RyanCoulsonCA]

For the last one, I'm not sure how Storylines even reacts to a slide with no panels. It's probably best we don't allow the user to remove the whole config... for now we'll say this is intentional, but maybe we should add a warning message.

Actually, my other open PR that does JSON validation already warns the user if the config is erased so we don't have to worry about this one.

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

[dnlnashed]

Sounds good 👍 . For the second issue the button sticks around for me

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

[RyanCoulsonCA]

Very interesting. I still can't seem to reproduce this one so I'll spin it into a new issue as well.

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)