Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor breaks if trying to access a panel that has been removed using advanced editor #321

Closed
RyanCoulsonCA opened this issue Jun 14, 2024 · 0 comments · Fixed by #366
Closed
Assignees
Labels
Bug Something isn't working Priority: High This task is high priority and should be tackled soon

Comments

@RyanCoulsonCA
Copy link
Member

Description

From @dnlnashed in #317:

When removing a panel using the advanced editor, if you click on the panel side that's been removed the slide editor ends up breaking

Steps to reproduce

  1. Go to the demo page and load a product.
  2. Click on a slide and go to the advanced editor tab.
  3. Remove the second panel config and then try to click on the Right panel tab.
  4. Notice that nothing happens and an error appears in the console.

Expected behavior

Two options: Either the tab should disappear immediately after the panel config is removed, or we should at least check if the panel still exists when the user clicks on the tab.

Actual behavior

Nothing happens and the editor breaks.

@RyanCoulsonCA RyanCoulsonCA added Bug Something isn't working Priority: High This task is high priority and should be tackled soon labels Jun 14, 2024
@yileifeng yileifeng self-assigned this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Priority: High This task is high priority and should be tackled soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants