-
Notifications
You must be signed in to change notification settings - Fork 741
rely on release/2.9 from test-infra and set version #4106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4106
Note: Links to docs will display an error until the docs builds have been completed. ❌ 34 New Failures, 1 Cancelled JobAs of commit 494bbb4 with merge base caba63f ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Something seems wrong with the wheel build jobs as they're installing torch 2.8 instead of 2.9RC |
See IIUC, we'll need to add |
| PYTORCH_WHEEL_INDEX="https://download.pytorch.org/whl/${UPLOAD_CHANNEL}/${GPU_ARCH_ID}" | ||
| pip install --progress-bar=off --pre torch torchcodec --index-url="${PYTORCH_WHEEL_INDEX}" | ||
| pip install --progress-bar=off --pre torch --index-url="${PYTORCH_WHEEL_INDEX}" | ||
| pip install --progress-bar=off --pre torchcodec --index-url="https://download.pytorch.org/whl/nightly/${GPU_ARCH_ID}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it mean that torchcodec must be released before torchaudio?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://github.com/pytorch/torchcodec/actions/runs/17490234874/job/49679289728, torchcodec 0.7.0 wheels are built against torch 2.8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort of, but to be more complete on what the issue is:
The previous
pip install --progress-bar=off --pre torch torchcodec --index-url="${PYTORCH_WHEEL_INDEX}"
would be trying to install both torch and torchcodec from the test channel, where the RCs are. Torch publishes RCs in there, but we haven't set that up in TorchCodec yet. So it's getting a very very old torchcodec version that we had pushed to test channel in the past, and it's not compatible with torch.
The workaround you see here just installs torchcodec from the nightly channel instead, hoping that it's ABI and API-compatible with torch. It's hacky a brittle, but it's the best we have until torchcodec pushes its RC wheel in the test channel
|
Waiting on https://github.com/pytorch/test-infra/pull/7150/files to land which should hopefully fix the torch version mismatch |
PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.