Skip to content

rely on release/2.9 from test-infra and set version #4106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 11, 2025
Merged

rely on release/2.9 from test-infra and set version #4106

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
084b42b
rely on release/2.9 from test-infra
NicolasHug Sep 11, 2025
a292a40
Set 2.9 version
NicolasHug Sep 11, 2025
494bbb4
Try to install torchcodec nightly for unittest cpu
NicolasHug Sep 11, 2025
c8c1774
This worked for test jobs. Do same for GPU test job
NicolasHug Sep 11, 2025
13fa2b6
empty
NicolasHug Sep 11, 2025
e1488d4
And same for doc job
NicolasHug Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build-wheels-m1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ permissions:

jobs:
generate-matrix:
uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main
uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@release/2.9
with:
package-type: wheel
os: macos-arm64
test-infra-repository: pytorch/test-infra
test-infra-ref: main
test-infra-ref: release/2.9
build:
needs: generate-matrix
strategy:
Expand All @@ -39,12 +39,12 @@ jobs:
smoke-test-script: test/smoke_test/smoke_test_no_ffmpeg.py
package-name: torchaudio
name: ${{ matrix.repository }}
uses: pytorch/test-infra/.github/workflows/build_wheels_macos.yml@main
uses: pytorch/test-infra/.github/workflows/build_wheels_macos.yml@release/2.9
with:
repository: ${{ matrix.repository }}
ref: ""
test-infra-repository: pytorch/test-infra
test-infra-ref: main
test-infra-ref: release/2.9
build-matrix: ${{ needs.generate-matrix.outputs.matrix }}
smoke-test-script: ${{ matrix.smoke-test-script }}
runner-type: macos-m1-stable
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build_wheels_aarch64_linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ permissions:

jobs:
generate-matrix:
uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main
uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@release/2.9
with:
package-type: wheel
os: linux-aarch64
test-infra-repository: pytorch/test-infra
test-infra-ref: main
test-infra-ref: release/2.9
with-cuda: enable
build:
needs: generate-matrix
Expand All @@ -40,12 +40,12 @@ jobs:
smoke-test-script: test/smoke_test/smoke_test.py
package-name: torchaudio
name: ${{ matrix.repository }}
uses: pytorch/test-infra/.github/workflows/build_wheels_linux.yml@main
uses: pytorch/test-infra/.github/workflows/build_wheels_linux.yml@release/2.9
with:
repository: ${{ matrix.repository }}
ref: ""
test-infra-repository: pytorch/test-infra
test-infra-ref: main
test-infra-ref: release/2.9
build-matrix: ${{ needs.generate-matrix.outputs.matrix }}
pre-script: ${{ matrix.pre-script }}
post-script: ${{ matrix.post-script }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build_wheels_linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ permissions:

jobs:
generate-matrix:
uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main
uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@release/2.9
with:
package-type: wheel
os: linux
test-infra-repository: pytorch/test-infra
test-infra-ref: main
test-infra-ref: release/2.9
with-xpu: enable
build:
needs: generate-matrix
Expand All @@ -40,12 +40,12 @@ jobs:
smoke-test-script: test/smoke_test/smoke_test_no_ffmpeg.py
package-name: torchaudio
name: ${{ matrix.repository }}
uses: pytorch/test-infra/.github/workflows/build_wheels_linux.yml@main
uses: pytorch/test-infra/.github/workflows/build_wheels_linux.yml@release/2.9
with:
repository: ${{ matrix.repository }}
ref: ""
test-infra-repository: pytorch/test-infra
test-infra-ref: main
test-infra-ref: release/2.9
build-matrix: ${{ needs.generate-matrix.outputs.matrix }}
smoke-test-script: ${{ matrix.smoke-test-script }}
package-name: ${{ matrix.package-name }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build_wheels_windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ permissions:

jobs:
generate-matrix:
uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main
uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@release/2.9
with:
package-type: wheel
os: windows
test-infra-repository: pytorch/test-infra
test-infra-ref: main
test-infra-ref: release/2.9
with-xpu: enable
build:
needs: generate-matrix
Expand All @@ -38,12 +38,12 @@ jobs:
smoke-test-script: test/smoke_test/smoke_test_no_ffmpeg.py
package-name: torchaudio
name: ${{ matrix.repository }}
uses: pytorch/test-infra/.github/workflows/build_wheels_windows.yml@main
uses: pytorch/test-infra/.github/workflows/build_wheels_windows.yml@release/2.9
with:
repository: ${{ matrix.repository }}
ref: ""
test-infra-repository: pytorch/test-infra
test-infra-ref: main
test-infra-ref: release/2.9
build-matrix: ${{ needs.generate-matrix.outputs.matrix }}
env-script: ${{ matrix.env-script }}
package-name: ${{ matrix.package-name }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ffmpeg.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
fail-fast: false
matrix:
ffmpeg_version: ["4.4.4", "5.1.4", "6.1.1", "master"]
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@release/2.9
permissions:
id-token: write
contents: read
Expand All @@ -42,7 +42,7 @@ jobs:
fail-fast: false
matrix:
ffmpeg_version: ["4.4.4", "5.1.4", "6.1.1", "master"]
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@release/2.9
permissions:
id-token: write
contents: read
Expand All @@ -69,7 +69,7 @@ jobs:
matrix:
ffmpeg_version: ["4.4.4", "5.1.4", "6.1.1", "master"]
runner: ["macos-m1-stable", "macos-12"]
uses: pytorch/test-infra/.github/workflows/macos_job.yml@main
uses: pytorch/test-infra/.github/workflows/macos_job.yml@release/2.9
with:
job-name: Build
upload-artifact: ffmpeg-lgpl
Expand All @@ -91,7 +91,7 @@ jobs:
fail-fast: false
matrix:
ffmpeg_version: ["4.4.4", "5.1.4", "6.1.1", "master"]
uses: pytorch/test-infra/.github/workflows/windows_job.yml@main
uses: pytorch/test-infra/.github/workflows/windows_job.yml@release/2.9
with:
job-name: Build
upload-artifact: ffmpeg-lgpl
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/unittest-linux-cpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
python-version: ["3.11"]
ffmpeg-version: ["7"]
fail-fast: false
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@release/2.9
permissions:
id-token: write
contents: read
Expand Down Expand Up @@ -62,7 +62,8 @@ jobs:

echo "::group::Install PyTorch and TorchCodec"
PYTORCH_WHEEL_INDEX="https://download.pytorch.org/whl/${UPLOAD_CHANNEL}/cpu"
python -m pip install --pre torch torchcodec --index-url="${PYTORCH_WHEEL_INDEX}"
python -m pip install --pre torch --index-url="${PYTORCH_WHEEL_INDEX}"
python -m pip install --pre torchcodec --index-url="https://download.pytorch.org/whl/nightly/cpu"
python -c 'import torch; print(f"{torch.__version__}"); print(f"{torch.__file__}")'
python -c 'import torchcodec; print(f"{torchcodec.__version__}"); print(f"{torchcodec.__file__}")'
echo "::endgroup::"
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/unittest-linux-gpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
python_version: ["3.10"]
cuda_arch_version: ["12.6"]
fail-fast: false
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@release/2.9
permissions:
id-token: write
contents: read
Expand Down Expand Up @@ -63,7 +63,8 @@ jobs:
echo "::group::Install PyTorch"
export GPU_ARCH_ID="cu126" # TODO this is currently hardcoded, should depend on matrix's value.
PYTORCH_WHEEL_INDEX="https://download.pytorch.org/whl/${UPLOAD_CHANNEL}/${GPU_ARCH_ID}"
pip install --progress-bar=off --pre torch torchcodec --index-url="${PYTORCH_WHEEL_INDEX}"
pip install --progress-bar=off --pre torch --index-url="${PYTORCH_WHEEL_INDEX}"
pip install --progress-bar=off --pre torchcodec --index-url="https://download.pytorch.org/whl/nightly/${GPU_ARCH_ID}"
Copy link
Collaborator

@pearu pearu Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean that torchcodec must be released before torchaudio?

Copy link
Collaborator

@pearu pearu Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://github.com/pytorch/torchcodec/actions/runs/17490234874/job/49679289728, torchcodec 0.7.0 wheels are built against torch 2.8.

Copy link
Member Author

@NicolasHug NicolasHug Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of, but to be more complete on what the issue is:

The previous

        pip install --progress-bar=off --pre torch torchcodec --index-url="${PYTORCH_WHEEL_INDEX}"

would be trying to install both torch and torchcodec from the test channel, where the RCs are. Torch publishes RCs in there, but we haven't set that up in TorchCodec yet. So it's getting a very very old torchcodec version that we had pushed to test channel in the past, and it's not compatible with torch.

The workaround you see here just installs torchcodec from the nightly channel instead, hoping that it's ABI and API-compatible with torch. It's hacky a brittle, but it's the best we have until torchcodec pushes its RC wheel in the test channel

echo "::endgroup::"

echo "::group::Install TorchAudio"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unittest-macos-cpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ env:

jobs:
tests:
uses: pytorch/test-infra/.github/workflows/macos_job.yml@main
uses: pytorch/test-infra/.github/workflows/macos_job.yml@release/2.9
with:
runner: macos-m1-stable
repository: pytorch/audio
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unittest-windows-cpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:

jobs:
unittests-windows-cpu:
uses: pytorch/test-infra/.github/workflows/windows_job.yml@main
uses: pytorch/test-infra/.github/workflows/windows_job.yml@release/2.9
with:
repository: pytorch/audio
runner: windows.4xlarge
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unittest-windows-gpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:

jobs:
unittests-windows-gpu:
uses: pytorch/test-infra/.github/workflows/windows_job.yml@main
uses: pytorch/test-infra/.github/workflows/windows_job.yml@release/2.9
with:
repository: pytorch/audio
runner: windows.g5.4xlarge.nvidia.gpu
Expand Down
2 changes: 1 addition & 1 deletion version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.8.0a0
2.9.0
Loading