Bump astroid to 4.0.3 #10798
Bump astroid to 4.0.3 #10798
Conversation
jacobtylerwalls
added
backport maintenance/4.0.x
Skip news 🔇
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10798 +/- ##
==========================================
- Coverage 95.98% 95.98% -0.01%
==========================================
Files 176 176
Lines 19566 19566
==========================================
- Hits 18781 18780 -1
- Misses 785 786 +1 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
|
Inference changed too much; not backporting. |
|
@cdce8p, would you know by eye whether the home assistance primer changes would trace back to the |
|
Bisected it to pylint-dev/astroid@3774c0a |
jacobtylerwalls
force-pushed
the
bump-astroid
branch
2 times, most recently
from
5979557 to
e22743b
Compare
jacobtylerwalls
removed
the
Skip news 🔇
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
I was also worried by the primer, maybe we need to make #9040 a blocker for 4.1.0 because that's a lot of false positives.
| .[testutils,spelling] | ||
| # astroid dependency is also defined in pyproject.toml | ||
| astroid==4.0.2 # Pinned to a specific version for tests | ||
| astroid==4.0.3 # Pinned to a specific version for tests |
There was a problem hiding this comment.
Shouldn't we choose between the pyproject.toml or this ? (I'm for using the pyproject)
There was a problem hiding this comment.
Yep I figure the plan is to remove these files?
pyproject.toml
Outdated
| # All the dependencies of the project will be configured here, once pip fully supports PEP735 | ||
| # TODO: Remove all requirements.txt files and use this section instead once pip supports PEP735 | ||
| dependencies = [ | ||
| # Also upgrade requirements_test_min.txt. |
There was a problem hiding this comment.
Or we could upgrade those kind of comments
|
But the new traffic into that issue is just from PEP 695 stuff, I'm not sure we should block on that. |
|
It look like the changes would make 'unexpected-keyword-arg' unusable in home-assistant ? |
|
Because that project is a heavy user of pep 695 and polymorphic dataclasses together, yes. |
|
I'm not sure how common that is, do you have an opinion @DanielNoord ? |
|
I agree with @jacobtylerwalls, we should probably just release. Perhaps we can snipe one of our other maintainers with a link to |
I've seen discussion here. Was just preoccupied with some other things this week so haven't had time to look into it yet. |
|
I just ran my Home Assistant CI setup again to test the latest astroid and pylint commits. Aside from that, I think you guys narrowed down the issue quite well already. My PR fixed an inference bug which now surfaces an old issue #9040 again. Thankfully Python 3.12 isn't the default yet, so I think the impact will be rather contained. -- Update: Please disregard the performance comment. Looks like it was just random CI runner variance. |
jacobtylerwalls
force-pushed
the
bump-astroid
branch
from
e22743b to
b192486
Compare
jacobtylerwalls
force-pushed
the
bump-astroid
branch
from
b192486 to
6653e6c
Compare
Pierre-Sassoulas
added
the
Maintenance
jacobtylerwalls
temporarily deployed
to
Backport
GitHub Actions
Inactive
4 participants
No description provided.