Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pending wallet address copy issue fixed #1326

Merged
merged 1 commit into from
May 31, 2024

Conversation

abhishek-01k
Copy link
Collaborator

When copying pending wallet address in the group info, only half of the wallet address was getting copied

#1297

Fixes Issue

Closes: #1297

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

0x9D964e3F0336acAB0AD2bA496a2Cb0cC5079F493 -> full wallet address gets copied
Screenshot 2024-05-28 at 5 40 07 PM

When copying pending wallet address in the group info, only half of the wallet address was getting
copied

#1297
Copy link

  • In the PendingMembers component, the import statement for Spinner is missing. It should be imported from '../../reusables'.

  • In the PendingMembers component, the ArrowImage component is using the Image styled component with incorrect props. It should be src={ArrowIcon} not background={ArrowIcon}.

  • In the PendingMembers component, the ProfileContainer component is passing the icon prop incorrectly. It should be icon: item?.userInfo?.profile?.picture || null instead of icon: item?.userInfo?.profile.picture || null.

  • In the PendingMembers component, the ProfileContainer component is passing a name prop with null value. It should be removed if not needed or passed with a valid value.

  • In the AcceptedMembers component, there is a missing import statement for MdError and MdCheckCircle icons. They should be imported from 'react-icons/md'.

  • In the AcceptedMembers component, the toast.showMessageToast function is calling handleError function with incorrect parameters. It should be handleError(error, SUCCESS_MESSAGE[UPDATE_KEYS.ADD_ADMIN]) instead of handleError(response, SUCCESS_MESSAGE[UPDATE_KEYS.ADD_ADMIN]).

  • In the AcceptedMembers component, the handleRemoveMember and handleModifyParticipant functions should use modifyLoading, addLoading, removeLoading to show loading states accordingly.

  • In the AcceptedMembers component, the handleModifyParticipant function has a logical error in the conditional statements. The error should be fixed to ensure the correct behavior.

  • In the AcceptedMembers component, the addAdminDropdown should be checking for GROUP_ROLES.MEMBER instead of GROUP_ROLES.ADMIN when adding an admin.

  • In the GroupPendingMembers styled component, the background property should use a function to access the theme object correctly. It should be background: ${(props) => props.theme.backgroundColor.modalHoverBackground};.

  • In the ArrowImage styled component, the rotate CSS property should be defined with the appropriate values for rotating the icon based on the setPosition prop.

  • In the Badge styled component, the color property should use the theme color for consistency. It should be color: ${(props) => props.theme.textColor.badgeText};.

  • In the ProfileSection styled component, the &::-webkit-scrollbar-thumb, &::-webkit-scrollbar-button, and &::-webkit-scrollbar styles are incorrect. They should be revised for correct scrollbar styling.

All looks good.

@abhishek-01k abhishek-01k merged commit 58636d0 into alpha May 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants