Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copying full wallet address in pending member list #1314

Closed
wants to merge 1 commit into from

Conversation

abhishek-01k
Copy link
Collaborator

Fixes Issue

Closes: #1297

Changes proposed

  • Now if you will copy the wallet address in the pending member list of group Info, full address will be copied.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copying wallet address was not copying full wallet address in the pending member list of group info
in push chat uiweb
Copy link

  • The import statements at the beginning of the file seem to be correct.
  • The UPDATE_KEYS object is defined using the as const assertion which is a good practice to ensure type safety.
  • The SUCCESS_MESSAGE object has success messages for various actions which is fine.
  • The PendingMembers component looks well-structured and handles pending members data and pagination correctly.
  • The AcceptedMembers component also seems well-structured and handles accepted members data and pagination along with actions like adding/removing members or admins.
  • The styled components are used effectively to style the components.

Overall, the code looks well-written and structured.

All looks good.

Copy link
Contributor

@mishramonalisha76 mishramonalisha76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image clicking on options icon the group info modal is half hidden

@abhishek-01k
Copy link
Collaborator Author

opened new PR for this #1326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants