-
Notifications
You must be signed in to change notification settings - Fork 45
8714 add show prop to popover-button #8755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
0c35c01
feat: add _show prop to popover-button
yurtsever 584740a
fix: reorder prop definition
yurtsever 20fb60f
fix: tests
yurtsever b0aea25
fix: revert table changes
yurtsever ca0d0b4
update: change show prop to open
yurtsever 8acf980
fix: revert open prop to show
yurtsever bbca1bb
fix: revert snapshot
yurtsever 299a231
Update all snapshots$
yurtsever 2320871
fix: validators and prop definitions
yurtsever 80baa1b
merge branch
yurtsever f676770
fix: Adjust prop docs and show prop validation
yurtsever 4618725
fix: update snapshot viewport
yurtsever 13b93e8
fix: snapshot viewport
yurtsever 5abd8cb
feat: add test case for default state
yurtsever c27ec59
fix: remove snapshot for windows
yurtsever 4c3c400
feat: add missing test code
yurtsever 8dfd7e7
Update all snapshots$
yurtsever 29e636c
Merge branch 'release/3' into 8714-add-show-prop
yurtsever 7bfc129
fix: handle popover after render
yurtsever 6151652
Merge branch 'release/3' into 8714-add-show-prop
yurtsever dc534f8
Merge branch 'release/3' into 8714-add-show-prop
yurtsever 2b2cecb
refactor: remove _show prop and related validation from KolPopoverBut…
deleonio 8be41d0
Update all snapshots$
yurtsever 8ad2f5d
fix: Remove tests for _show prop
yurtsever bc3ee56
Merge branch 'release/3' into 8714-add-show-prop
yurtsever 0acdd36
Update all snapshots$
yurtsever File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleonio marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-602 Bytes
(91%)
...mer/snapshots/theme-default/snapshot-for-popover-button-basic-firefox-linux.png
deleonio marked this conversation as resolved.
Show resolved
Hide resolved
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-602 Bytes
(91%)
...ult/snapshots/theme-default/snapshot-for-popover-button-basic-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.