8714 add show prop to popover-button #8755
Conversation
Add optional ´_show´ prop to control the popover visibility state programmatically. When set to true, the popover opens initially on component load. Refs: #8714
|
🚀 MCP preview deployed to Vercel: https://kolibri-m42cz6401-public-ui-kolibri-mcp.vercel.app |
|
Netlify Draft Deployment |
deleonio
left a comment
deleonio
left a comment
There was a problem hiding this comment.
Snapshots aktualisieren - bitte: das geht über Actions und Snapshot updaten und branch auswählen.
packages/components/src/components/table-stateless/test/snapshot.spec.tsx
Show resolved
Hide resolved
|
@yurtsever Bitte alle PRs sauber mit Ticket verknüpfen. Traceability |
packages/components/src/components/popover-button/component.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/popover-button/component.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/popover-button/component.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/popover-button/component.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/popover-button/component.tsx
Outdated
Show resolved
Hide resolved
...name-transformer/snapshots/theme-default/snapshot-for-popover-button-basic-firefox-linux.png
Show resolved
Hide resolved
packages/components/src/components/popover-button/component.tsx
Outdated
Show resolved
Hide resolved
...s/themes/default/snapshots/theme-default/snapshot-for-popover-button-basic-firefox-win32.png
Outdated
Show resolved
Hide resolved
yurtsever
force-pushed
the
8714-add-show-prop
branch
from
01e0d77 to
c27ec59
Compare
$ Refs: #8714
| validateShow(this, value); | ||
| } | ||
|
|
||
| public componentDidLoad() { |
There was a problem hiding this comment.
Es muss nach dem Render passieren: https://stenciljs.com/docs/component-lifecycle
There was a problem hiding this comment.
Wenn man die show prop initial auf true setzt und show- bzw. hide-popover in der componentDidRender aufruft macht dann schließt sich der popover nicht.
Wenn die prop initial auf false gesetzt wird öffnet sich der popover erst nach dem zweiten Klick.
Ist das das gewünschte verhalten ?
deleonio
left a comment
deleonio
left a comment
There was a problem hiding this comment.
Ich habe gerade gesehen, dass noch ein Punkt offen ist.
This Adds a optional _show prop to control the popover visibility state programmatically.
When set to true, the popover opens initially on component load.