Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CEL code migration #1
CEL code migration #1
Changes from 167 commits
e2dc904
ec1e761
1f99801
3dd3a8e
4926bcf
38c50ee
63d7297
e4c7864
0bf660f
251b861
94e6629
0e734a3
9cea08a
9354da1
a0b4b8a
ec64493
f6c7007
e1cee25
a178488
468ae7e
ed4e291
b737391
53d85a6
7e909f3
99cce3f
c3e244e
3cbcf30
a75f76f
6f9992d
b59114f
c69c1b4
b80d58c
7ea8e67
179c3ff
3a845d4
9413086
64ee9ac
b5c6709
9c3f5ea
743b98d
0d002ef
0aede24
2e702c8
9f98396
f58b6b9
45adf7f
d46a116
5fe59e0
ebb2e4c
0f825bc
aa903c4
69c1df5
38c2905
d0ebfff
8515f90
8678198
79168cf
fbad942
6b33aee
96d9ba7
470d9c7
ef4967b
0199c1c
b85d881
18dfcff
7951657
ef72ea1
9a7ceb9
51da1d9
ce3ec4e
a877a05
c9ae5b7
e9e2905
7b5bc06
0aeb208
6c5d2d5
82b2643
47bca29
0a74a85
5957abb
5bf527e
0188f53
fd24a03
df178f3
92d2d1c
ee38113
45e673a
805ee01
bfb9d13
39e79b5
d6ad6f6
9b4a277
293729b
ec81cbb
e853e6f
0252950
dfd5e8f
643e87a
c40f0c4
c06fcbe
dc1c181
564601b
f7dbc56
f96e57a
f6321ef
45ac6ce
0be477b
58ab910
bdc76c5
901cede
f5b6872
1624945
fd12ca8
40c83d4
1a6e267
a10ac23
6f864ee
75bbba8
d23bcd6
4467d76
e52c0e3
ba841d8
de7d2cc
7e56aa0
be22d06
b6dc6cd
2e97669
db671a8
e83311b
2014cb5
2e9c213
942313c
b4d3edc
6837a4c
9406819
cfd259e
35806d0
9482583
d3e86ad
70cb7aa
54b07c7
3185249
5ace89c
4eb0db0
82f485f
f1cd6cd
5b94339
b87a919
6fa7b89
8ed0d7e
7ef9ca8
f1cb8d9
b6e9112
d8bb1ca
39b7c84
5a23931
60f37fd
1aff611
f34ea27
71297f6
ebb4670
357aca2
2b851bd
12d427e
7190fed
4ee85e8
549800f
be06f90
3711fb1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're interested, the Makefile over in protobom/storage has a target to run all the tests and print out a coverage report. Up to you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll start improving all the machinery once we check-in the code. This are stripped version of the files originally written to release the bomshell binary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want to enable this, or no? Up to you, just following up from my other comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nlreturn? I just tried it and it highlighted a ton of issues, I'm not sure I want to deal with those now :S