CEL code migration #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit checks in the bomshell poc working with the protobom libs before the first functions of the elements APIs were built. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit modifies the shell to return the execution resutls instead of just printing it. Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
This commit modifies the main package to use a new cmd package which implements a new cobrabased cli. The CLI has two subcommands, the root which launches the interactive shell and exec which is intended to run CEL bomshell scripts from the CLI and printout the result. Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit modifies bomshell to support loading multiple SBOMs into the bomshell environment. The --sbom flag in the exec subcommand now can be specified multiple times. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit adds the first composing function: RelateNodeListAtID() This method takes a nodelist and remixes it by relating it to a node in an SBOM or nodelist. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo Garcia Veytia (puerco) <[email protected]>
jhoward-lm
reviewed
Jan 16, 2025
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
jhoward-lm
approved these changes
Jan 16, 2025
Comment on lines
+23
to
+26
| - name: Test | ||
| run: | | ||
| go get -d ./... | ||
| go test -v ./... |
There was a problem hiding this comment.
If you're interested, the Makefile over in protobom/storage has a target to run all the tests and print out a coverage report. Up to you
There was a problem hiding this comment.
I'll start improving all the machinery once we check-in the code. This are stripped version of the files originally written to release the bomshell binary.
Makefile
Outdated
|
|
||
| .PHONY: sbom | ||
| sbom: | ||
| cd dist && bom generate -c ../.bom.yaml -o sbom.spdx.json --format=json |
There was a problem hiding this comment.
Just curious, why not
Suggested change
| cd dist && bom generate -c ../.bom.yaml -o sbom.spdx.json --format=json | |
| bom generate -c .bom.yaml -o dist/sbom.spdx.json --format=json |
There was a problem hiding this comment.
I've pushed a change with it, but don't pay a lot of attention to the Makefile, all of this needs to be implemented as the repo is now a library and not a binary.
| # - lll | ||
| # - nestif | ||
| # - nilerr | ||
| # - nlreturn |
There was a problem hiding this comment.
Did you want to enable this, or no? Up to you, just following up from my other comment
There was a problem hiding this comment.
nlreturn? I just tried it and it highlighted a ton of issues, I'm not sure I want to deal with those now :S
puerco
force-pushed
the
initial-checkin
branch
from
75d4ed1 to
51abf5d
Compare
This commit fixes the native type adapter. It was missing all the protobom elements. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
puerco
force-pushed
the
initial-checkin
branch
from
51abf5d to
3711fb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the bomshell CEL module into the protobom project. This PR refactors the CEl module to make it more general purpose while preserving the whole history from the original bomshell project to recognize the folks that worked on it.
This is still in draft but I wanted to open it for early reviews.