Skip to content

Update OM 2.0 with proposal#43 Created Timestamp syntax #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ArthurSens
Copy link
Member

Updates OpenMetrics 2.0 with our discussions in the working group and prometheus/proposals#43

cc @Maniktherana

@ArthurSens ArthurSens force-pushed the om-created-timestamps branch from ee584fd to f24c2ab Compare May 29, 2025 14:47
@krajorama krajorama changed the title Update OM 2.0 with proposal#43 Update OM 2.0 with proposal#43 Created Timestamp syntax May 30, 2025
@ArthurSens ArthurSens force-pushed the om-created-timestamps branch from 77a1036 to 8d8e083 Compare May 31, 2025 21:17
Copy link
Member

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some small corrections. Also as per WG decision, you'll need another approval.

@ArthurSens
Copy link
Member Author

Approved with some small corrections. Also as per WG decision, you'll need another approval.

Thanks for clarifying about exemplars :)

@ArthurSens ArthurSens requested a review from dashpole June 11, 2025 13:25
@krajorama
Copy link
Member

I wonder if @ct needs to be prohibited explicitly for gauges, gauge histograms and alike. The ABNF does allow it, so syntax doesn't restrict, needs to be a semantic rule.

ArthurSens and others added 7 commits June 26, 2025 18:38
Signed-off-by: Arthur Silva Sens <[email protected]>
Co-authored-by: George Krajcsovits <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Co-authored-by: George Krajcsovits <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Co-authored-by: George Krajcsovits <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
@ArthurSens ArthurSens force-pushed the om-created-timestamps branch from c5566b9 to 68c966d Compare June 26, 2025 21:47
@ArthurSens
Copy link
Member Author

ArthurSens commented Jun 26, 2025

Comments addressed, thanks for the review!

I wonder if @ct needs to be prohibited explicitly for gauges, gauge histograms and alike. The ABNF does allow it, so syntax doesn't restrict, needs to be a semantic rule.

Do we mean that we need to be explicit in the Gauge/Gauge Histogram definition that they do not have created timestamps? The current definition doesn't say that created timestamps exist for them, so we can rely on the implicit information that those types don't have CT...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants