Skip to content

Commit 68c966d

Browse files
committed
Address comments
Signed-off-by: Arthur Silva Sens <[email protected]>
1 parent 3351215 commit 68c966d

File tree

1 file changed

+21
-21
lines changed

1 file changed

+21
-21
lines changed

docs/specs/om/open_metrics_spec_2_0.md

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ MetricFamilies of type Info MUST have an empty Unit string.
216216

217217
Histograms measure distributions of discrete events. Common examples are the latency of HTTP requests, function runtimes, or I/O request sizes.
218218

219-
A Histogram MetricPoint MUST contain at least one bucket, and SHOULD contain Sum, and Created values. Every bucket MUST have a threshold and a value.
219+
A Histogram MetricPoint MUST contain at least one bucket, and SHOULD contain Sum, and Created Values. Every bucket MUST have a threshold and a value.
220220

221221
Histogram MetricPoints MUST have one bucket with an +Inf threshold. Buckets MUST be cumulative. As an example for a metric representing request latency in seconds its values for buckets with thresholds 1, 2, 3, and +Inf MUST follow value_1 <= value_2 <= value_3 <= value_+Inf. If ten requests took 1 second each, the values of the 1, 2, 3, and +Inf buckets MUST equal 10.
222222

@@ -408,8 +408,8 @@ An example of a complete exposition:
408408
# HELP acme_http_router_request_seconds Latency though all of ACME's HTTP request router.
409409
acme_http_router_request_seconds_sum{path="/api/v1",method="GET"} 9036.32 [email protected]
410410
acme_http_router_request_seconds_count{path="/api/v1",method="GET"} 807283.0 [email protected]
411-
acme_http_router_request_seconds_sum{path="/api/v2",method="POST"} 479.3 ct@1605281325.0
412-
acme_http_router_request_seconds_count{path="/api/v2",method="POST"} 34.0 ct@1605281325.0
411+
acme_http_router_request_seconds_sum{path="/api/v2",method="POST"} 479.3 ct@1605301325.0
412+
acme_http_router_request_seconds_count{path="/api/v2",method="POST"} 34.0 ct@1605301325.0
413413
# TYPE go_goroutines gauge
414414
# HELP go_goroutines Number of goroutines that currently exist.
415415
go_goroutines 69
@@ -643,21 +643,21 @@ An example with a Metric with no labels, and a MetricPoint with no timestamp and
643643
foo_total 17.0
644644
```
645645

646-
An example with a Metric with no labels, and a MetricPoint with a timestamp and no created:
646+
An example with a Metric with no labels, and a MetricPoint with a timestamp and no Created Value:
647647

648648
```openmetrics-add-eof
649649
# TYPE foo counter
650650
foo_total 17.0 1520879607.789
651651
```
652652

653-
An example with a Metric with no labels, and a MetricPoint with no timestamp and a created:
653+
An example with a Metric with no labels, and a MetricPoint with no timestamp and a Created Value:
654654

655655
```openmetrics-add-eof
656656
# TYPE foo counter
657657
foo_total 17.0 [email protected]
658658
```
659659

660-
An example with a Metric with no labels, and a MetricPoint with a timestamp and a created:
660+
An example with a Metric with no labels, and a MetricPoint with a timestamp and a Created Value:
661661

662662
```openmetrics-add-eof
663663
# TYPE foo counter
@@ -666,7 +666,7 @@ foo_total 17.0 1520879607.789 [email protected]
666666

667667
Exemplars MAY be attached to the MetricPoint's Total sample.
668668

669-
An example with a Metric with no labels, and a MetricPoint with a timestamp and a created and an exemplar:
669+
An example with a Metric with no labels, and a MetricPoint with a timestamp and a Created Value and an exemplar:
670670

671671
```
672672
# TYPE foo counter
@@ -725,17 +725,17 @@ Metric labels and MetricPoint value labels MAY be in any order.
725725

726726
If present, the MetricPoint's Sum Value Sample MetricName MUST have the suffix `_sum`. If present, the MetricPoint's Count Value MetricName MUST have the suffix `_count`. If present, the MetricPoint's Quantile Values MUST specify the quantile measured using a label with a label name of "quantile" and with a label value of the quantile measured.
727727

728-
If present the MetricPoint's Created Value MUST be inlined with the Metric point with a `ct@` prefix. If the value's timestamp is present, the Created Value MUST be added right after it. If exemplar is present, the Created Value MUST be added before it. Createad Value MUST be appended to all Quantile Values, to the MetricPoint's Sum and MetricPoint's Count.
728+
If present the MetricPoint's Created Value MUST be inlined with the Metric point with a `ct@` prefix. If the value's timestamp is present, the Created Value MUST be added right after it. If exemplar is present, the Created Value MUST be added before it. Created Value MUST be appended to all Quantile Values, to the MetricPoint's Sum and MetricPoint's Count.
729729

730-
An example of a Metric with no labels and a MetricPoint with Sum, Count and Created values:
730+
An example of a Metric with no labels and a MetricPoint with Sum, Count and Created Values:
731731

732732
```openmetrics-add-eof
733733
# TYPE foo summary
734734
foo_count 17.0 [email protected]
735735
foo_sum 324789.3 [email protected]
736736
```
737737

738-
An example of a Metric with no labels and a MetricPoint with two quantiles and Created values:
738+
An example of a Metric with no labels and a MetricPoint with two quantiles and Created Values:
739739

740740
```openmetrics-add-eof
741741
# TYPE foo summary
@@ -749,26 +749,26 @@ Quantiles MAY be in any order.
749749

750750
The MetricPoint's Bucket Values Sample MetricNames MUST have the suffix `_bucket`. If present, the MetricPoint's Sum Value Sample MetricName MUST have the suffix `_sum`.
751751

752-
If present the MetricPoint's Created Value MUST be inlined with the Metric point with a `ct@` prefix. If the value's timestamp is present, the Created Value MUST be added right after it. If exemplar is present, the Created Value MUST be added before it. Createad Value MUST be appended to all Bucket Values, to the MetricPoint's Sum and MetricPoint's Count.
752+
If present the MetricPoint's Created Value MUST be inlined with the Metric point with a `ct@` prefix. If the value's timestamp is present, the Created Value MUST be added right after it. If exemplar is present, the Created Value MUST be added before it. Created Value MUST be appended to all Bucket Values, to the MetricPoint's Sum and MetricPoint's Count.
753753

754754
If and only if a Sum Value is present in a MetricPoint, then the MetricPoint's +Inf Bucket value MUST also appear in a Sample with a MetricName with the suffix "_count".
755755

756756
Buckets MUST be sorted in number increasing order of "le", and the value of the "le" label MUST follow the rules for Canonical Numbers.
757757

758-
An example of a Metric with no labels and a MetricPoint with Sum, Count, and Created values, and with 12 buckets. A wide and atypical but valid variety of “le” values is shown on purpose:
758+
An example of a Metric with no labels and a MetricPoint with Sum, Count, and Created Values, and with 12 buckets. A wide and atypical but valid variety of “le” values is shown on purpose:
759759

760760
```openmetrics-add-eof
761761
# TYPE foo histogram
762762
foo_bucket{le="0.0"} 0 [email protected]
763-
foo_bucket{le="1e-05"} 0 ct@1520430000.123
764-
foo_bucket{le="0.0001"} 5 ct@1520430000.123
765-
foo_bucket{le="0.1"} 8 ct@1520430000.123
766-
foo_bucket{le="1.0"} 10 ct@1520430000.123
767-
foo_bucket{le="10.0"} 11 ct@1520430000.123
768-
foo_bucket{le="100000.0"} 11 ct@1520430000.123
769-
foo_bucket{le="1e+06"} 15 ct@1520430000.123
770-
foo_bucket{le="1e+23"} 16 ct@1520430000.123
771-
foo_bucket{le="1.1e+23"} 17 ct@1520430000.123
763+
foo_bucket{le="1e-05"} 0 ct@1521430000.123
764+
foo_bucket{le="0.0001"} 5 ct@1521430020.123
765+
foo_bucket{le="0.1"} 8 ct@1520430321.123
766+
foo_bucket{le="1.0"} 10 ct@1522430000.123
767+
foo_bucket{le="10.0"} 11 ct@1520430123.123
768+
foo_bucket{le="100000.0"} 11 ct@1521430010.123
769+
foo_bucket{le="1e+06"} 15 ct@1520430301.123
770+
foo_bucket{le="1e+23"} 16 ct@1521430001.123
771+
foo_bucket{le="1.1e+23"} 17 ct@1522430220.123
772772
foo_bucket{le="+Inf"} 17 [email protected]
773773
foo_count 17 [email protected]
774774
foo_sum 324789.3 [email protected]

0 commit comments

Comments
 (0)