fix(voice): correct padding amount calculation #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an incorrect calculation of voice padding introduced with 618f306, where the last byte was incorrectly unwrapped into a typed array. Ref: abalabahaha/eris#1558 (comment) Ref: https://datatracker.ietf.org/doc/html/rfc3550#section-5.1
TTtie
added
the
scope: voice
TTtie
pushed a commit
that referenced
this pull request
Nov 17, 2025
This is rare, but sometimes some packets are given with *only* padding inside them, #229 fixed the issue of handling padding properly so that it's not passed to the `data` event, but empty buffers while in a DAVE session leads to failed decryptions. This usually occurs in Cloudflare-ran voice servers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an incorrect calculation of voice padding introduced with 618f306, where the last byte was incorrectly unwrapped into a typed array.
Ref: abalabahaha/eris#1558 (comment)
Ref: https://datatracker.ietf.org/doc/html/rfc3550#section-5.1