fix(voice): correct padding amount calculation (#229)

TTtie · web-flow · commit 11cf04e9325b · 2025-11-10T12:32:28.000Z
Fixes an incorrect calculation of voice padding introduced with 618f306, where the last byte was incorrectly unwrapped into a typed array. Ref: abalabahaha/eris#1558 (comment) Ref: https://datatracker.ietf.org/doc/html/rfc3550#section-5.1
diff --git a/lib/voice/VoiceConnection.js b/lib/voice/VoiceConnection.js
@@ -964,7 +964,7 @@ class VoiceConnection extends EventEmitter {
 
             // RFC3550 5.1: Padding (may need testing)
             if(hasPadding) {
-                const paddingAmount = data.subarray(0, data.length - 1);
+                const paddingAmount = data[data.length - 1];
                 if(paddingAmount < data.length) {
                     data = data.subarray(0, data.length - paddingAmount);
                 }

Original file line number	Diff line number	Diff line change
`@@ -964,7 +964,7 @@ class VoiceConnection extends EventEmitter {`
`964`	`964`
`965`	`965`	`// RFC3550 5.1: Padding (may need testing)`
`966`	`966`	`if(hasPadding) {`
`967`		`- const paddingAmount = data.subarray(0, data.length - 1);`
	`967`	`+ const paddingAmount = data[data.length - 1];`
`968`	`968`	`if(paddingAmount < data.length) {`
`969`	`969`	`data = data.subarray(0, data.length - paddingAmount);`
`970`	`970`	`}`