Skip to content

Alias: Do not inherit the GVL ID from the parent by default #4641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sigma-software-prebid wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Alias: Do not inherit the GVL ID from the parent by default #4641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions config/bidderinfo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ type BidderInfo struct {
ModifyingVastXmlAllowed bool `yaml:"modifyingVastXmlAllowed" mapstructure:"modifyingVastXmlAllowed"`
Debug *DebugInfo `yaml:"debug" mapstructure:"debug"`
Geoscope []string `yaml:"geoscope" mapstructure:"geoscope"`
GVLVendorID uint16 `yaml:"gvlVendorID" mapstructure:"gvlVendorID"`
GVLVendorID *uint16 `yaml:"gvlVendorID" mapstructure:"gvlVendorID"`

Syncer *Syncer `yaml:"userSync" mapstructure:"userSync"`

Expand Down Expand Up @@ -391,7 +391,7 @@ func processBidderAliases(aliasNillableFieldsByBidder map[string]aliasNillableFi
if aliasBidderInfo.ExtraAdapterInfo == "" {
aliasBidderInfo.ExtraAdapterInfo = parentBidderInfo.ExtraAdapterInfo
}
if aliasBidderInfo.GVLVendorID == 0 {
if aliasBidderInfo.GVLVendorID == nil {
Copy link
Contributor

@SyntaxNode SyntaxNode Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this still have the behavior of inheriting the GVL ID from the parent by default?

Copy link
Contributor Author

@sigma-software-prebid sigma-software-prebid Dec 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SyntaxNode According to the requirements in #4463, we now will have 3 cases:

  1. If we do not have GVL ID in configs and it is nil then we inherit from parent (default behavior).
  2. If we have GVL ID == 0 then we do not inherit from parent and use zero as value.
  3. If GVL ID != 0 meaning it is present and is not equal to zero then we have own value and we use it (also do not inherit from parent).

Copy link
Collaborator

@bsardo bsardo Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SyntaxNode perhaps we should tweak the requirements so an alias never inherits the GVL ID to be safe? If the alias has the same GVL ID as its parent it would need to explicitly declare that GVL ID. Thoughts?

aliasBidderInfo.GVLVendorID = parentBidderInfo.GVLVendorID
}
if aliasBidderInfo.Maintainer == nil {
Expand Down Expand Up @@ -433,8 +433,8 @@ func processBidderAliases(aliasNillableFieldsByBidder map[string]aliasNillableFi
func (infos BidderInfos) ToGVLVendorIDMap() map[openrtb_ext.BidderName]uint16 {
gvlVendorIds := make(map[openrtb_ext.BidderName]uint16, len(infos))
for name, info := range infos {
if info.IsEnabled() && info.GVLVendorID != 0 {
gvlVendorIds[openrtb_ext.BidderName(name)] = info.GVLVendorID
if info.IsEnabled() && info.GVLVendorID != nil && *info.GVLVendorID != 0 {
gvlVendorIds[openrtb_ext.BidderName(name)] = *info.GVLVendorID
}
}
return gvlVendorIds
Expand Down Expand Up @@ -727,7 +727,7 @@ func applyBidderInfoConfigOverrides(configBidderInfos nillableFieldBidderInfos,
if configBidderInfo.bidderInfo.Debug != nil {
mergedBidderInfo.Debug = configBidderInfo.bidderInfo.Debug
}
if configBidderInfo.bidderInfo.GVLVendorID > 0 {
if configBidderInfo.bidderInfo.GVLVendorID != nil && *configBidderInfo.bidderInfo.GVLVendorID > 0 {
mergedBidderInfo.GVLVendorID = configBidderInfo.bidderInfo.GVLVendorID
}
if configBidderInfo.bidderInfo.XAPI.Username != "" {
Expand Down
124 changes: 106 additions & 18 deletions config/bidderinfo_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func TestLoadBidderInfoFromDisk(t *testing.T) {
Maintainer: &MaintainerInfo{
Email: "[email protected]",
},
GVLVendorID: 42,
GVLVendorID: ptrutil.ToPtr[uint16](42),
Capabilities: &CapabilitiesInfo{
App: &PlatformInfo{
MediaTypes: []openrtb_ext.BidType{openrtb_ext.BidTypeBanner, openrtb_ext.BidTypeNative},
Expand Down Expand Up @@ -142,7 +142,7 @@ func TestProcessBidderInfo(t *testing.T) {
Maintainer: &MaintainerInfo{
Email: "[email protected]",
},
GVLVendorID: 42,
GVLVendorID: ptrutil.ToPtr[uint16](42),
},
},
expectError: "",
Expand Down Expand Up @@ -203,7 +203,7 @@ func TestProcessBidderInfo(t *testing.T) {
},
},
ExtraAdapterInfo: "extra-info",
GVLVendorID: 42,
GVLVendorID: ptrutil.ToPtr[uint16](42),
Maintainer: &MaintainerInfo{
Email: "[email protected]",
},
Expand Down Expand Up @@ -255,7 +255,7 @@ func TestProcessBidderInfo(t *testing.T) {
},
},
ExtraAdapterInfo: "extra-info",
GVLVendorID: 42,
GVLVendorID: ptrutil.ToPtr[uint16](42),
Maintainer: &MaintainerInfo{
Email: "[email protected]",
},
Expand Down Expand Up @@ -316,7 +316,7 @@ func TestProcessAliasBidderInfo(t *testing.T) {
},
},
ExtraAdapterInfo: "extra-info",
GVLVendorID: 42,
GVLVendorID: ptrutil.ToPtr[uint16](42),
Maintainer: &MaintainerInfo{
Email: "[email protected]",
},
Expand Down Expand Up @@ -364,7 +364,7 @@ func TestProcessAliasBidderInfo(t *testing.T) {
},
},
ExtraAdapterInfo: "alias-extra-info",
GVLVendorID: 43,
GVLVendorID: ptrutil.ToPtr[uint16](43),
Maintainer: &MaintainerInfo{
Email: "[email protected]",
},
Expand Down Expand Up @@ -561,10 +561,10 @@ func mockNormalizeBidderName(name string) (openrtb_ext.BidderName, bool) {

func TestToGVLVendorIDMap(t *testing.T) {
givenBidderInfos := BidderInfos{
"bidderA": BidderInfo{Disabled: false, GVLVendorID: 0},
"bidderB": BidderInfo{Disabled: false, GVLVendorID: 100},
"bidderC": BidderInfo{Disabled: true, GVLVendorID: 0},
"bidderD": BidderInfo{Disabled: true, GVLVendorID: 200},
"bidderA": BidderInfo{Disabled: false, GVLVendorID: ptrutil.ToPtr[uint16](0)},
"bidderB": BidderInfo{Disabled: false, GVLVendorID: ptrutil.ToPtr[uint16](100)},
"bidderC": BidderInfo{Disabled: true, GVLVendorID: ptrutil.ToPtr[uint16](0)},
"bidderD": BidderInfo{Disabled: true, GVLVendorID: ptrutil.ToPtr[uint16](200)},
}

expectedGVLVendorIDMap := map[openrtb_ext.BidderName]uint16{
Expand Down Expand Up @@ -594,7 +594,7 @@ func TestBidderInfoValidationPositive(t *testing.T) {
Maintainer: &MaintainerInfo{
Email: "[email protected]",
},
GVLVendorID: 1,
GVLVendorID: ptrutil.ToPtr[uint16](1),
Capabilities: &CapabilitiesInfo{
App: &PlatformInfo{
MediaTypes: []openrtb_ext.BidType{
Expand All @@ -618,7 +618,7 @@ func TestBidderInfoValidationPositive(t *testing.T) {
Maintainer: &MaintainerInfo{
Email: "[email protected]",
},
GVLVendorID: 2,
GVLVendorID: ptrutil.ToPtr[uint16](2),
Capabilities: &CapabilitiesInfo{
Site: &PlatformInfo{
MediaTypes: []openrtb_ext.BidType{
Expand Down Expand Up @@ -659,7 +659,7 @@ func TestBidderInfoValidationPositive(t *testing.T) {
Maintainer: &MaintainerInfo{
Email: "[email protected]",
},
GVLVendorID: 3,
GVLVendorID: ptrutil.ToPtr[uint16](3),
Capabilities: &CapabilitiesInfo{
DOOH: &PlatformInfo{
MediaTypes: []openrtb_ext.BidType{
Expand Down Expand Up @@ -2209,15 +2209,15 @@ func TestApplyBidderInfoConfigOverrides(t *testing.T) {
},
{
description: "Don't override GVLVendorID",
givenFsBidderInfos: BidderInfos{"a": {GVLVendorID: 5}},
givenFsBidderInfos: BidderInfos{"a": {GVLVendorID: ptrutil.ToPtr[uint16](5)}},
givenConfigBidderInfos: nillableFieldBidderInfos{"a": {bidderInfo: BidderInfo{Syncer: &Syncer{Key: "override"}}}},
expectedBidderInfos: BidderInfos{"a": {GVLVendorID: 5, Syncer: &Syncer{Key: "override"}}},
expectedBidderInfos: BidderInfos{"a": {GVLVendorID: ptrutil.ToPtr[uint16](5), Syncer: &Syncer{Key: "override"}}},
},
{
description: "Override GVLVendorID",
givenFsBidderInfos: BidderInfos{"a": {}},
givenConfigBidderInfos: nillableFieldBidderInfos{"a": {bidderInfo: BidderInfo{GVLVendorID: 5, Syncer: &Syncer{Key: "override"}}}},
expectedBidderInfos: BidderInfos{"a": {GVLVendorID: 5, Syncer: &Syncer{Key: "override"}}},
givenConfigBidderInfos: nillableFieldBidderInfos{"a": {bidderInfo: BidderInfo{GVLVendorID: ptrutil.ToPtr[uint16](5), Syncer: &Syncer{Key: "override"}}}},
expectedBidderInfos: BidderInfos{"a": {GVLVendorID: ptrutil.ToPtr[uint16](5), Syncer: &Syncer{Key: "override"}}},
},
{
description: "Don't override XAPI",
Expand Down Expand Up @@ -2396,7 +2396,7 @@ func TestReadFullYamlBidderConfig(t *testing.T) {
Maintainer: &MaintainerInfo{
Email: "[email protected]",
},
GVLVendorID: 42,
GVLVendorID: ptrutil.ToPtr[uint16](42),
Capabilities: &CapabilitiesInfo{
App: &PlatformInfo{
MediaTypes: []openrtb_ext.BidType{openrtb_ext.BidTypeBanner, openrtb_ext.BidTypeVideo, openrtb_ext.BidTypeNative},
Expand Down Expand Up @@ -2448,6 +2448,94 @@ func TestReadFullYamlBidderConfig(t *testing.T) {
assert.Equalf(t, expectedBidderInfo, actualBidderInfo, "Bidder info objects aren't matching")
}

func TestAliasGVLVendorIDInheritance(t *testing.T) {
testCases := []struct {
name string
parentGVLVendorID *uint16
aliasGVLVendorID *uint16
expectedAliasGVLID *uint16
expectedInGVLMap bool
expectedGVLMapValue uint16
description string
}{
{
name: "alias with nil GVL ID inherits from parent",
parentGVLVendorID: ptrutil.ToPtr[uint16](42),
aliasGVLVendorID: nil,
expectedAliasGVLID: ptrutil.ToPtr[uint16](42),
expectedInGVLMap: true,
expectedGVLMapValue: 42,
description: "When alias GVLVendorID is nil, it should inherit parent's GVL vendor ID",
},
{
name: "alias with zero GVL ID uses its own value",
parentGVLVendorID: ptrutil.ToPtr[uint16](42),
aliasGVLVendorID: ptrutil.ToPtr[uint16](0),
expectedAliasGVLID: ptrutil.ToPtr[uint16](0),
expectedInGVLMap: false,
expectedGVLMapValue: 0,
description: "When alias GVLVendorID is 0, it should keep its own value and not inherit",
},
{
name: "alias with non-zero GVL ID uses its own value",
parentGVLVendorID: ptrutil.ToPtr[uint16](42),
aliasGVLVendorID: ptrutil.ToPtr[uint16](99),
expectedAliasGVLID: ptrutil.ToPtr[uint16](99),
expectedInGVLMap: true,
expectedGVLMapValue: 99,
description: "When alias GVLVendorID is non-zero, it should keep its own value",
},
}

for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
parentBidderInfo := BidderInfo{
Disabled: false,
GVLVendorID: tc.parentGVLVendorID,
Maintainer: &MaintainerInfo{
Email: "[email protected]",
},
Capabilities: &CapabilitiesInfo{
Site: &PlatformInfo{
MediaTypes: []openrtb_ext.BidType{openrtb_ext.BidTypeBanner},
},
},
}

aliasBidderInfo := BidderInfo{
AliasOf: "parentBidder",
Disabled: false,
GVLVendorID: tc.aliasGVLVendorID,
}

bidderInfos := BidderInfos{
"parentBidder": parentBidderInfo,
"aliasBidder": aliasBidderInfo,
}

aliasNillableFields := map[string]aliasNillableFields{
"aliasBidder": {},
}

result, err := processBidderAliases(aliasNillableFields, bidderInfos)
assert.NoError(t, err)

processedAlias := result["aliasBidder"]
assert.NotNil(t, processedAlias.GVLVendorID, tc.description)
assert.Equal(t, *tc.expectedAliasGVLID, *processedAlias.GVLVendorID, tc.description)
gvlMap := result.ToGVLVendorIDMap()
if tc.expectedInGVLMap {
vendorID, exists := gvlMap["aliasBidder"]
assert.True(t, exists, "Alias should appear in GVL vendor map: "+tc.description)
assert.Equal(t, tc.expectedGVLMapValue, vendorID, "GVL vendor ID in map should match expected value")
} else {
_, exists := gvlMap["aliasBidder"]
assert.False(t, exists, "Alias should not appear in GVL vendor map: "+tc.description)
}
})
}
}

func TestValidateGeoscope(t *testing.T) {
testCases := []struct {
name string
Expand Down
2 changes: 1 addition & 1 deletion config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,7 +1139,7 @@ func TestBidderInfoFromEnv(t *testing.T) {
assert.Equal(t, `{"extrainfo": true}`, cfg.BidderInfos["bidder1"].ExtraAdapterInfo)

assert.Equal(t, true, cfg.BidderInfos["bidder1"].Debug.Allow)
assert.Equal(t, uint16(42), cfg.BidderInfos["bidder1"].GVLVendorID)
assert.Equal(t, uint16(42), *cfg.BidderInfos["bidder1"].GVLVendorID)

assert.Equal(t, true, cfg.BidderInfos["bidder1"].Experiment.AdsCert.Enabled)
assert.Equal(t, "username_override", cfg.BidderInfos["bidder1"].XAPI.Username)
Expand Down
Loading