Alias: Do not inherit the GVL ID from the parent by default #4641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
reviewed
Dec 22, 2025
| aliasBidderInfo.ExtraAdapterInfo = parentBidderInfo.ExtraAdapterInfo | ||
| } | ||
| if aliasBidderInfo.GVLVendorID == 0 { | ||
| if aliasBidderInfo.GVLVendorID == nil { |
Contributor
There was a problem hiding this comment.
Wouldn't this still have the behavior of inheriting the GVL ID from the parent by default?
Contributor
Author
There was a problem hiding this comment.
@SyntaxNode According to the requirements in #4463, we now will have 3 cases:
- If we do not have GVL ID in configs and it is
nilthen we inherit from parent (default behavior). - If we have GVL ID == 0 then we do not inherit from parent and use zero as value.
- If GVL ID != 0 meaning it is present and is not equal to zero then we have own value and we use it (also do not inherit from parent).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
#4463
🧠 Rationale behind the change
An alias should not inherit the GVL ID from the parent by default. There should be a way to detect GVL ID presence in the alias config. If not provided, inherit from the parent. If set to 0, that indicates no GVL ID and do not inherit from the parent.
In scope of this change
GVLVendorID's type has been changed to pointer.🧪 Test plan
Functionality is covered by
TestAliasGVLVendorIDInheritanceunit test inconfig/bidderinfo_test.go.