Skip to content

Commit

Permalink
Disable orientation by default on non-mobile devices that may have ac…
Browse files Browse the repository at this point in the history 
…celerometers (#10)
  • Loading branch information
@brianchirls
brianchirls committed Oct 5, 2015
1 parent 414a829 commit 69859a4
Show file tree
Hide file tree
Showing 5 changed files with 145 additions and 122 deletions.
Loading

6 comments on commit 69859a4

@bby
Copy link

@bby bby commented on 69859a4 Oct 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to have mistakenly identified and disabled orientation (only get full screen button) on Nexus 5 phone, running marshmallow. It is working on S3.

@bby
Copy link

@bby bby commented on 69859a4 Oct 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick update, looks like this might be a Marshmallow specific thing. Tested on Nexus Tablet running Lollipop and no issues. Previously mentioned S3 was Jellybean (Samsung borked)

@brianchirls
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should not have any effect on whether you see the orientation button. The button should appear soon as the first deviceorientation event fires.

Are all these devices running the same version of Chrome? Does orientation work with other apps on the Nexus 5? How about other web pages?

@bby
Copy link

@bby bby commented on 69859a4 Oct 19, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianchirls
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the research. That's frustrating and, frankly, typical of the kind of regressions that I often see in mobile browsers. I have starred the issue and will be keeping an eye on it.

@bby
Copy link

@bby bby commented on 69859a4 Oct 19, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.