Rename id of orientation button to orientation-button (#10)

In Firefox and possibly some versions of Chrome, having an element with an id of `orientation` replaced the `window.orientation` numerical value with a pointer to the element. This appears to be fixed in upcoming versions of Firefox, but I'm renaming it anyway to fix it in the current version and any other browsers where it may be an issue. Orientation in Firefox is still wonky, but that's a separate matter.
povdocs · Oct 4, 2015 · 414a829 · 414a829
1 parent ec651b2
commit 414a829
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/build/vr.dev.js b/build/vr.dev.js
diff --git a/build/vr.js b/build/vr.js
diff --git a/build/vr.js.map b/build/vr.js.map
diff --git a/src/entry.js b/src/entry.js
@@ -111,7 +111,7 @@
 		vrButton.className = 'unsupported';
 		vrButton.addEventListener('click', VR.requestVR, false);
 
-		orientationButton = svgButton(require('raw!open-iconic/svg/compass.svg'), 'orientation');
+		orientationButton = svgButton(require('raw!open-iconic/svg/compass.svg'), 'orientation-button');
 		orientationButton.setAttribute('title', 'Toggle Orientation');
 		orientationButton.className = 'unsupported';
 		orientationButton.addEventListener('click', toggleOrientation, false);