Miscellaneous Dockerfile.hail etc fixes to precipitate rebuilding the driver image #735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to access this field directly, as an API function was added for the purpose back in Hail 0.2.121.
Quote metacharacters to avoid redirecting pip output to /=3.8.0 oops. Remove 1.3Gb of build cache from the image. Avoid obsolete ENV syntax.
dancoates
approved these changes
Jul 22, 2025
Contributor
dancoates
left a comment
dancoates
left a comment
There was a problem hiding this comment.
Looks good, just one small note
| statsmodels | ||
| 'selenium>=3.8.0' \ | ||
| statsmodels && \ | ||
| rm -rf /root/.cache /tmp/tmp* |
Contributor
There was a problem hiding this comment.
It would be good to add a comment here describing what these cache files are and why they should be deleted.
Contributor
Author
|
D'oh… Should have done a bumpversion if I wanted the tiny server/ar.py change to get deployed via a new PyPI package. Nevermind, there's no behaviour change anyway so it can just come along for the ride next time this code actually gets updated. (And it turns out the deploy_server action is workflow-dispatch-only, not also on pushes to main…) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to build a new driver image containing cpg-utils 5.4.1, i.e., the corrected two-argument
image_path()as per populationgenomics/cpg-utils#185.As an excuse to build a new image, this PR collects some miscellaneous minor fixes. Most notably, the hail build leaves 1.3Gb of cached maven, mill, and pip dependencies in
/root/.cache, and the GCP SDK installation leaves a script in/tmp/tmp.RANDOMHASH.