replace : with - to avoid repo cloning issue on windows #7
Conversation
WalkthroughThe recent updates primarily address corrections to file naming conventions in various scripts and configuration file paths, switching from colon ( Changes
Sequence Diagram(s)File Checking Process (Before and After Update) sequenceDiagram
participant User
participant Script
participant FileSystem
User->>Script: Run processFiles
Script->>FileSystem: Check for file "eip155-*.json"
FileSystem-->>Script: File found/not found
Script-->>User: Processed file list
Connection Hops (Before and After Update) sequenceDiagram
participant App
participant findConnectionHops
participant ConfigFiles
App->>findConnectionHops: getConnectionHops(source, destination)
findConnectionHops->>ConfigFiles: Load srcConfigPath
findConnectionHops->>ConfigFiles: Load destConfigPath
ConfigFiles-->>findConnectionHops: Return configurations
findConnectionHops-->>App: Return connection hops
Poem
Tip AI model upgrade
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (3)
utils/findConnectionHops.js (3)
21-21: Minor whitespace adjustment.The whitespace adjustment improves readability.
- function getConnectionHops (source, destination) { + function getConnectionHops(source, destination) {
24-24: Minor whitespace adjustment.The whitespace adjustment improves readability.
- const proofsConHops = [srcConfig.polymer.clients['op-client'].canonConnFrom, destConfig.polymer.clients['op-client'].canonConnTo]; + const proofsConHops = [srcConfig.polymer.clients['op-client'].canonConnFrom, destConfig.polymer.clients['op-client'].canonConnTo];
53-53: Minor whitespace adjustment.The whitespace adjustment improves readability.
- }; +};
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- README.md (1 hunks)
- utils/buildOutput.js (1 hunks)
- utils/findConnectionHops.js (3 hunks)
- utils/getPortID.js (1 hunks)
Files skipped from review due to trivial changes (2)
- README.md
- utils/getPortID.js
Additional comments not posted (2)
utils/buildOutput.js (1)
20-20: Correct filename condition to avoid Windows cloning issues.The condition to check filenames has been updated to use
eip155-instead ofeip155:. This change aligns with the new naming convention and resolves the issue with Windows cloning.utils/findConnectionHops.js (1)
10-10: Correct file path format to avoid Windows cloning issues.The paths for configuration files have been updated to use hyphens instead of colons. This change aligns with the new naming convention and resolves the issue with Windows cloning.
For open-ibc/ibc-app-solidity-template#87
Can attest that cloning this repo is not possible on windows prior to this change.
E.g.
git clone https://github.com/polymerdao/polymer-registry.gitfailsbut
git clone -b ian/dev https://github.com/polymerdao/polymer-registry.gitworksThis change means our file names no longer match the chain-id format convention in https://chainagnostic.org/CAIPs/caip-2 but I think that is okay because the same output is produced in dist/output.json. The
clientMapis left unchanged as well, still mapping to ids using the caip-2 convention.