Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update polymer registry dep #88

Merged
merged 1 commit into from
Oct 8, 2024
Merged

update polymer registry dep #88

merged 1 commit into from
Oct 8, 2024

Conversation

i-norden
Copy link
Contributor

@i-norden i-norden commented Jul 8, 2024

Fix for #87 using polymerdao/polymer-registry#7

Summary by CodeRabbit

  • Chores
    • Updated subproject commit hash for lib/polymer-registry to integrate the latest changes.

Copy link
Contributor

coderabbitai bot commented Jul 8, 2024

Walkthrough

The change in the lib/polymer-registry subproject updates the commit hash from f1283abd5c7a98032564b7828ffc04b2064cabc5 to 303b15f4990733920aa2fe07b69af01354fcb68a. This update likely incorporates various bug fixes, performance enhancements, or internal optimizations. Notably, no modifications were made to the declarations of exported or public entities, indicating the external API remains the same.

Changes

File/Directory Change Summary
lib/.../polymer-registry Updated subproject commit hash from f1283abd5c7a98032564b7828ffc04b2064cabc5 to 303b15f4990733920aa2fe07b69af01354fcb68a. No changes to public API.

Poem

In the land of code so neat,
A hash did take a quiet leap,
From old to new, in subtle sweep,
The registry now plays a beat,
Of changes made, though none to greet.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@i-norden i-norden self-assigned this Jul 8, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between aedff00 and 3ac5189.

Files selected for processing (1)
  • lib/polymer-registry (1 hunks)
Files skipped from review due to trivial changes (1)
  • lib/polymer-registry

@i-norden
Copy link
Contributor Author

i-norden commented Jul 8, 2024

Unfortunately, fixing this clone issue only exposed further issues on Windows related to the MAX_PATH limit it enforces on path lengths.

fatal: cannot write keep file 'C:/Users/ianno/github/ibc-app-solidity-template/.git/modules/lib/vibc-core-smart-contracts/modules/lib/optimism/modules/packages/contracts-bedrock/lib/clones-with-immutable-args/modules/lib/ds-test/objects/pack/pack-7f56f56907d0ef629b2e0344644d535164a3c5c8.keep': Filename too long
fatal: fetch-pack: invalid index-pack output
fatal: clone of 'https://github.com/dapphub/ds-test' into submodule path 'C:/Users/ianno/github/ibc-app-solidity-template/lib/vibc-core-smart-contracts/lib/optimism/packages/contracts-bedrock/lib/clones-with-immutable-args/lib/ds-test' failed

@i-norden i-norden merged commit c42e7f3 into main Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants